8357146: ForkJoinPool:schedule(*) does not throw RejectedExecutionException when pool is shutdown

[DougLea]

Method startDelayScheduler should trap the ISE thrown by SharedThreadContainer.start and possibly re-try termination before eventually throwing RejectedExecutionException.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357146: ForkJoinPool:schedule(*) does not throw RejectedExecutionException when pool is shutdown (Bug - P3)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25431/head:pull/25431
$ git checkout pull/25431

Update a local copy of the PR:
$ git checkout pull/25431
$ git pull https://git.openjdk.org/jdk.git pull/25431/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25431

View PR using the GUI difftool:
$ git pr show -t 25431

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25431.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DougLea This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357146: ForkJoinPool:schedule(*) does not throw RejectedExecutionException when pool is shutdown

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• a300c35: 8357105: C2: compilation fails with "assert(false) failed: empty program detected during loop optimization"
• bd09589: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base
• daa8eda: 8357056: RISC-V: Asm fixes - load/store width
• ... and 14 more: https://git.openjdk.org/jdk/compare/e89330579d5f38e282512211711fffeeea3e899e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@DougLea The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (675aff74)
• 00: Full (eeb5119e)

[AlanBateman]

This reset okay, and the schedule methods will throw REE. The change makes me wonder about the OOME "unable to create new native thread" scenario, should the schedule methods propagate it or throw REE with the OOME as cause?

[DougLea]

OOME (not REE) is thrown if the creation fails in the try-finally, which seems best. But if start() throws OOME (or any other Error), I see that we should do the same back-out as with ISE, but rethrow it now vs rely on the the REE in schedule(). I'll adjust accordingly.

[AlanBateman]

Latest version looks good, and Thread.start throwing OOME will be propagated.

[DougLea]

/integrate

[openjdk]

Going to push as commit 2c034f5.
Since your change was applied there have been 19 commits pushed to the master branch:

• bbceab0: 8352251: Implement JEP 518: JFR Cooperative Sampling
• e8eff4d: 8357530: C2 SuperWord: Diagnostic flag AutoVectorizationOverrideProfitability
• a300c35: 8357105: C2: compilation fails with "assert(false) failed: empty program detected during loop optimization"
• ... and 16 more: https://git.openjdk.org/jdk/compare/e89330579d5f38e282512211711fffeeea3e899e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DougLea Pushed as commit 2c034f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.