Skip to content

Eliminate bounds check for CharacterDataLatin1 #25434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wenshao
Copy link
Contributor

@wenshao wenshao commented May 25, 2025

The length of the CharacterDataLatin1::A and CharacterDataLatin1::B arrays is 256. The code that accesses the arrays in the getProperties and getPropertiesEx methods can use & 0xff to eliminate bounds checks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25434/head:pull/25434
$ git checkout pull/25434

Update a local copy of the PR:
$ git checkout pull/25434
$ git pull https://git.openjdk.org/jdk.git pull/25434/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25434

View PR using the GUI difftool:
$ git pr show -t 25434

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25434.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2025

👋 Welcome back swen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 25, 2025

@wenshao The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@ExE-Boss
Copy link

ch & 0xFF can also be used in CharacterDataLatin1​::digits​(int, int).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants