8359493: Refactor how aggregated mandatory warnings are handled in the compiler #25810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler's handling of the aggregation of mandatory warnings into "notes" at the end of compilation can be refactored to simplify the code.
The
JCDiagnostic
class supports flags that alter how warnings are handled, e.g.,MANDATORY
,NON_DEFERRABLE
, etc. So instead of having to log aggregated mandatory warnings through a separate channel (theMandatoryWarningHandler
), these warnings could instead be logged just like any other warning, but with anAGGREGATED
flag added. The actual aggregation can then be handled "behind the scenes" by the logging subsystem.This will also make it easier to implement
@SuppressAnnotations
support for parser/tokenizer warnings which require aggregated mandatory warning notes such as warnings for preview features.Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25810/head:pull/25810
$ git checkout pull/25810
Update a local copy of the PR:
$ git checkout pull/25810
$ git pull https://git.openjdk.org/jdk.git pull/25810/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25810
View PR using the GUI difftool:
$ git pr show -t 25810
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25810.diff
Using Webrev
Link to Webrev Comment