8359207: Remove runtime/signal/TestSigusr2.java since it is always skipped

[sendaoYan]

Hi all,

The test runtime/signal/TestSigusr2.java has jtreg tag @requires os.family != "windows" & os.family != "aix", and this test will skip on linux or macos(https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/runtime/signal/SigTestDriver.java#L59). Thus this test is always skipped indeed. So I want to removed this test. Test-fix only, no rsik.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359207: Remove runtime/signal/TestSigusr2.java since it is always skipped (Bug - P4)

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25825/head:pull/25825
$ git checkout pull/25825

Update a local copy of the PR:
$ git checkout pull/25825
$ git pull https://git.openjdk.org/jdk.git pull/25825/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25825

View PR using the GUI difftool:
$ git pr show -t 25825

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25825.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359207: Remove runtime/signal/TestSigusr2.java since it is always skipped

Reviewed-by: dcubed, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• a16d235: 8359402: Test CloseDescriptors.java should throw SkippedException when there is no lsof/sctp
• e55ddab: 8359223: HttpClient: Remove leftovers from the SecurityManager cleanup
• 9a1c1f2: 8357847: (ch) AsynchronousFileChannel implementations should support FFM Buffers
• ... and 7 more: https://git.openjdk.org/jdk/compare/fedd0a0ee3aea9f73cfce34172a764e63c1ba46b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d351cdf8)

[dcubed-ojdk]

"redundant" implies that the functionality is tested elsewhere. I have changed the bug's synopsis from:

Remove redundant runtime/signal/TestSigusr2.java

to:

Remove runtime/signal/TestSigusr2.java since it is always skipped

which I think is more accurate.

I wonder if SIGUSR2 was only useful on Solaris.

[dcubed-ojdk]

Please use "/issue JDK-8359207" as the easiest way to sync the PR title with the synopsis.

[dcubed-ojdk]

Thumbs up on the code changes.

[sendaoYan]

/issue JDK-8359207

[openjdk]

@sendaoYan This issue is referenced in the PR title - it will now be updated.

[sendaoYan]

Thanks for the correction and review @dcubed-ojdk

[dholmes-ora]

I wonder if SIGUSR2 was only useful on Solaris.

IIRC only testable on Solaris because there we had a special dedicated signal for suspend/resume. On all the *X platforms SIGUSR2 is used as SR_signum, and so can't be tested by this test.

[dholmes-ora]

LGTM2.

Thanks

[sendaoYan]

Thanks @dcubed-ojdk @dholmes-ora for the correction and reviews.

/integrate

[openjdk]

Going to push as commit 51877f5.
Since your change was applied there have been 15 commits pushed to the master branch:

• c1deb9e: 8356556: AArch64: No need for acquire fence in safepoint poll in FFM
• f62f117: 8359701: G1: Move heap expansion time tracking of G1CollectedHeap:expand to call site
• a082082: 8354650: [PPC64] Try to reduce register definitions
• ... and 12 more: https://git.openjdk.org/jdk/compare/fedd0a0ee3aea9f73cfce34172a764e63c1ba46b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 51877f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.