8359701: G1: Move heap expansion time tracking of G1CollectedHeap:expand to call site

[albertnetymk]

Simple patch of moving time-tracking logic from callee to caller, which removes a default arg. The default-arg is there because there are other callers that don't use/need this time-tracking logic.

Test: tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359701: G1: Move heap expansion time tracking of G1CollectedHeap:expand to call site (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25835/head:pull/25835
$ git checkout pull/25835

Update a local copy of the PR:
$ git checkout pull/25835
$ git pull https://git.openjdk.org/jdk.git pull/25835/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25835

View PR using the GUI difftool:
$ git pr show -t 25835

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25835.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359701: G1: Move heap expansion time tracking of G1CollectedHeap:expand to call site

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• a082082: 8354650: [PPC64] Try to reduce register definitions
• f7cd3fa: 8332623: Remove setTTL()/getTTL() methods from DatagramSocketImpl/MulticastSocket and MulticastSocket.send(DatagramPacket, byte)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (50fcbc22)
• 00: Full (2c358c59)

[tschatzl]

Suggested change

	Ticks expand_start_instant = Ticks::now();
	Ticks expand_start = Ticks::now();

It is very unusual to add an _instant postfix to similar variables, regardless of whether using Ticks or the elapsedTime API, so I suggested to remove it.

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit f62f117.
Since your change was applied there have been 2 commits pushed to the master branch:

• a082082: 8354650: [PPC64] Try to reduce register definitions
• f7cd3fa: 8332623: Remove setTTL()/getTTL() methods from DatagramSocketImpl/MulticastSocket and MulticastSocket.send(DatagramPacket, byte)

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit f62f117.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.