8359761: JDK 25 RDP1 L10n resource files update #25839

alisenchung · 2025-06-17T01:22:31Z

This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8359761: JDK 25 RDP1 L10n resource files update (Bug - P3)

Reviewers

Alexander Matveev (@sashamatveev - Reviewer) 🔄 Re-review required (review applies to 2dfac379)
Nizar Benalla (@nizarbenalla - Committer) 🔄 Re-review required (review applies to d8027691)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25839/head:pull/25839
$ git checkout pull/25839

Update a local copy of the PR:
$ git checkout pull/25839
$ git pull https://git.openjdk.org/jdk.git pull/25839/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25839

View PR using the GUI difftool:
$ git pr show -t 25839

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25839.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-06-17T01:23:12Z

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-06-17T01:23:23Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

openjdk · 2025-06-17T01:23:54Z

@alisenchung The following labels will be automatically applied to this pull request:

client
compiler
core-libs
javadoc
jmx
kulla
security
serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

openjdk · 2025-06-17T20:11:08Z

@alisenchung Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

openjdk · 2025-06-17T23:07:32Z

@alisenchung Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

mlbridge · 2025-06-17T23:11:14Z

Webrevs

alisenchung · 2025-06-17T23:11:25Z

whitespace changes are fixed, PR is ready for review

justin-curtis-lu · 2025-06-17T23:13:45Z

src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/resources/jdeprscan_de.properties

@@ -23,7 +23,7 @@
 # questions.
 #

-main.usage=Verwendung: jdeprscan [Optionen] '{dir|jar|class}' ...\n\nOptionen:\n        --class-path PATH\n        --for-removal\n        --full-version\n  -? -h --help\n  -l    --list\n        --release {0}\n  -v    --verbose\n        --version
+main.usage=Verwendung: jdeprscan [Optionen] ''{dir|jar|class}'' ...\n\nOptionen:\n        --class-path PATH\n        --for-removal\n        --full-version\n  -? -h --help\n  -l    --list\n        --release {0}\n  -v    --verbose\n        --version


Extra quotes, applies to other localized versions as well. (Usual change we revert)

justin-curtis-lu · 2025-06-17T23:15:05Z

src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2001, 2024, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2001, 2023, Oracle and/or its affiliates. All rights reserved.


Looks wrong but is correct. File had its copyright year updated in https://bugs.openjdk.org/browse/JDK-8345800, but the original is still 2023. Translation team is re-syncing it to match the original year.

Is there any way to prevent this or do we just change it back when we do a drop and explain why each time?

If this is committed, then the years will be synced and we won't have to change it back. This would be consistent with the way we receive l10n translations which sync the copyright years of localized files to the original.

If we want to deviate from this then we could file a request asking them to not update copyright years and we could update them ourselves.

justin-curtis-lu · 2025-06-17T23:15:23Z

src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2012, 2024, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 2012, 2021, Oracle and/or its affiliates. All rights reserved.


Same as my comment in src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java

justin-curtis-lu · 2025-06-17T23:22:08Z

src/java.base/share/classes/sun/security/tools/keytool/resources/keytool_de.properties

@@ -27,7 +27,7 @@ NEWLINE=\n
 STAR=*******************************************
 STARNN=*******************************************\n\n
 # keytool: Help part
-.OPTION.=\u0020[OPTION]...
+.OPTION.=\ [OPTION]...


We spoke about this offline. This is fine, property file values need to either start with a \ or \u0020 to denote intentional leading white space. In this case, since we convert to UTF-8 native characters from escape sequences this gets included as well. Functionally, they are equivalent and the new form works well with the translation process.

sashamatveev

jdk.jpackage changes looks good.

naotoj · 2025-06-18T01:51:28Z

src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage_de.properties

@@ -0,0 +1,68 @@
+#


Just wondering why this resource file has not been translated into de/ja/zh_CN till now. Looks correct though.

I am wondering the same thing. Perhaps because it is not intended for general public, it's not in the JDK tools specifications.
If that was intentionally left out, I don't see new reason to add them.

This file wasn't originally in the tbom file when we first restarted translations and was picked up by our getChanges tool because of a recent update to the file some time after the previous drop, so it hasn't been translated until this drop. Maybe the previous team just forgot to translate this file?

Thanks. I guess this was simply an overlook in the first place, as the process was manual back then.

nizarbenalla

I'm unable to confirm the accuracy of the translations, since I don't speak the target languages. I've only reviewed the jdk.javadoc sources.

All keys in the English property files match one-to-one with those in the non-English files: there are no missing or extra entries. The only changes are to the .properties files, exactly as the PR title suggests.

From the jdk.javadoc perspective, this looks good, so I'm happy to approve this PR.

jsikstro · 2025-06-18T09:47:57Z

Should the other localizations for the launcher help text (in launcher_<lang>.properties) also be updated? I see that only the German, Japanese and Chinese localizations have been updated so far.

Edit: I see that the other localizations haven't been updated for the last few releases, so maybe this is intentional. Still interested to know why we have the other localizations if they aren't updated.

aivanov-jdk · 2025-06-18T14:45:32Z

src/demo/share/jfc/SwingSet2/resources/swingset_de.properties

 SliderDemo.majorticks=Grobteilungen
-SliderDemo.majorticksdescription=Ein Schieberegler mit Grobteilungsmarkierungen
+SliderDemo.majorticksdescription=Ein Schieberegler mit Hauptteilstrichen


Should the translation of SliderDemo.majorticks also be updated?

I agree. I'd expect consistency here.

What would be the correct translation of majorticks here?

If "major tick" is translated to "Hauptteilstrich", then the plural would be [SliderDemo.majorticks=]Hauptteilstriche (which is a rather artificial word so the translation team might want to come up with a better translation for "major tick").

Microsoft uses Hauptteilstrich, see MajorTickMark Klasse, so Hauptteilstrich (singular Nominative) seems correct.

Ja, "Hauptteilstrich" and "Hauptteilstriche" (pl) are correct.

aivanov-jdk · 2025-06-18T14:48:13Z

src/demo/share/jfc/SwingSet2/resources/swingset_de.properties

 SliderDemo.ticks=Feinteilungen, Teilungen zum Einrasten und Labels
 SliderDemo.minorticks=Feinteilungen


The following description uses different words now:

Feinteilungen -> Teilstrichen
Teilungen -> Teilstrichen

Just to clarify, does this mean

SliderDemo.ticks=Teilstrichen, Teilstrichen zum Einrasten und Labels SliderDemo.minorticks=Teilstrichen

is correct?

Hm… I don't know. You should clarify with the translation team. They've changed the translation for the major ticks from Grobteilungen to Hauptteilstriche. Yet minor ticks remain Feinteilungen, which doesn't look right because the main word is different. (Teilung doesn't seem to be the right word, at least dictionaries translate it as “division”.)

Teilstrich means scale line, the marks on a ruler, so it fits.

Microsoft documentation for MinorTickMark Klasse uses Kleinere Teilstriche, yet I don't understand why there's ‘-e’ ending (plural?).

SliderDemo.ticks=Teilstrichen, Teilstrichen zum Einrasten und Labels

This one looks particularly incorrect; “einrasten“ is a verb with a separable prefix that means “to lock”, and I can't find a usage as if it's a noun.

The English phrase is “Minor Ticks, Snap-to-ticks and Labels”, and I don't know how to correctly translate it to German.

aivanov-jdk · 2025-06-18T15:24:46Z

src/java.base/share/classes/sun/security/util/resources/security_de.properties

-Subject.=Subjekt:\n
+Subject.=Subject:\n


Is it correct? German usually uses k.

aivanov-jdk · 2025-06-18T15:25:42Z

src/java.base/share/classes/sun/security/tools/keytool/resources/keytool_de.properties

-Generating.full.keyAlgName.key.pair.and.a.certificate.sigAlgName.issued.by.signerAlias.with.a.validity.of.days.for=Schlüsselpaar {0} und Zertifikat ({1}) werden generiert, das von <{2}> mit einer Gültigkeit von {3} Tagen ausgestellt wurde\n\tfür: {4}
+size.bit.alg=%1$d-Bit-%2$s
+Generating.full.keyAlgName.key.pair.and.self.signed.certificate.sigAlgName.with.a.validity.of.days.for=Generieren von {0}-Schlüsselpaar und selbstsigniertem Zertifikat ({1}) mit einer Gültigkeit von {2} Tagen\n\tfür: {3}
+Generating.full.keyAlgName.key.pair.and.a.certificate.sigAlgName.issued.by.signerAlias.with.a.validity.of.days.for=Generieren von {0}-Schlüsselpaar und einem von <{2}> ausgestellten Zertifikat ({1}) mit einer Gültigkeit von {3} Tagen\n\tfür: {4}


It feels as if there's something missing after ‘einem’.

seems ok to me, einem von X ausgestellten Zertifikat ~ einem Zertifikat, das von X ausgestellt wurde

aivanov-jdk · 2025-06-18T15:28:49Z

src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties

-LoginModuleControlFlag.=LoginModuleControlFlag:\u0020
+LoginModuleControlFlag.=LoginModuleControlFlag：\u0020


Is it intended to have two spaces instead of one? Or am I missing anything? The colon on the modified line looks slightly differently.

There is still only one space, the new one is a full width colon (U+FF1A). Localization rules have been observed to make the switch from regular colons (U+003A) into the full width version depending on the language.

Thank you for the clarification.

However, there is no space required between two Chinese sentences. In English, we usually write "I am here, and you are there." But in Chinese, with the full-width punctuation, it's always "我在这里，你在那里。".

Some people like to insert a space between a Chinese character and a Latin letter. I’m not a fan of this style, but I don’t feel strongly about it. However, adding a space between two Chinese characters or between a Chinese character and a full-width punctuation mark is unusual.

aivanov-jdk · 2025-06-18T15:34:38Z

src/demo/share/jfc/SwingSet2/resources/swingset_de.properties

Shall the copyright year be updated?

In the past, we usually don't modify the copyright years and the translation team syncs the localized variants with the original file. In this case the original file did not have a change, simply the translations were updated with a "newer version".

This is weird… Usually, the copyright year is bumped up whenever the file is edited.

aivanov-jdk · 2025-06-18T15:52:15Z

src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties

+codesigners.different.for.entry.1.when.reading.jarfile.and.jarinputstream=Codesignaturgeber für Eintrag %s beim Lesen über JarFile anders als bei JarInputStream
+entry.1.is.signed.in.jarfile.but.is.not.signed.in.jarinputstream=Eintrag %s ist in JarFile, aber nicht in JarInputStream signiert
+entry.1.is.signed.in.jarinputstream.but.is.not.signed.in.jarfile=Eintrag %s ist in JarInputStream, aber nicht in JarFile signiert
+jar.contains.internal.inconsistencies.result.in.different.contents.via.jarfile.and.jarinputstream=Diese JAR-Datei enthält interne Inkonsistenzen, die zu anderem Inhalt beim Lesen über JarFile als beim Lesen über JarInputStream führen können:


Is it expected to have “JAR_-Datei_”? It was removed from .verified and .signed strings.

I think it is because the English version of the properties file uses "jar" for .verified and .signed strings, but jar.contains.internal.inconsistencies.result.in.different.contents.via.jarfile.and.jarinputstream uses "JAR".

I see the entries for

jar.signed.=jar signed. jar.verified.=jar verified.

don't have the word “file”, whereas …via.jarfile.and.jarinputstream has it: “This JAR file…”

aivanov-jdk · 2025-06-18T15:59:35Z

...k.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_de.properties

 doclet.search_in_documentation=In Dokumentation suchen
 doclet.search_reset=Zurücksetzen
+doclet.Member=Member


Is Member translated? Should it be “Mitglied”?

Good catch. Usually, we file these issues with the translation team and make the appropriate updates in the second L10n drop. I think this one is fine to be updated now as well.

naotoj · 2025-06-18T16:55:36Z

Should the other localizations for the launcher help text (in launcher_<lang>.properties) also be updated? I see that only the German, Japanese and Chinese localizations have been updated so far.

Those languages (de/ja/zh-CN) are the ones we (Oracle) support. Other entities would be welcome to provide l10n for other languages (not a sporadic l10n, but commit to update/maintain).

Edit: I see that the other localizations haven't been updated for the last few releases, so maybe this is intentional. Still interested to know why we have the other localizations if they aren't updated.

Usuallly l10n resource updates are additions, so those old l10ns still have values for those languages. New additions will simply fall back to English.

src/demo/share/jfc/SwingSet2/resources/swingset_de.properties

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_de.properties

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher_de.properties

wangweij · 2025-06-24T14:59:18Z

src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties

-Subject.=主体: \n
-.Principal.=\t主用户:\u0020
+Subject.=主体：\n
+.Principal.=\t主用户：\u0020
 .Public.Credential.=\t公共身份证明:\u0020
 .Private.Credential.=\t专用身份证明:\u0020


Why aren't the 2 lines above updated like in lines 46 and 47?

Co-authored-by: Christian Stein <[email protected]>

…avac_de.properties Co-authored-by: Christian Stein <[email protected]>

…auncher_de.properties Co-authored-by: Christian Stein <[email protected]>

openjdk bot added javadoc [email protected] security [email protected] serviceability [email protected] jmx [email protected] client [email protected] core-libs [email protected] compiler [email protected] kulla [email protected] labels Jun 17, 2025

alisenchung force-pushed the 8359761 branch from ee4ed7b to ef9dfb6 Compare June 17, 2025 19:57

redo ws fixes, add manual changes

fda4acd

alisenchung force-pushed the 8359761 branch from 93472ae to fda4acd Compare June 17, 2025 23:07

openjdk bot added the rfr Pull request is ready for review label Jun 17, 2025

empty commit

2dfac37

justin-curtis-lu reviewed Jun 17, 2025

View reviewed changes

fix unicode escapes

d802769

sashamatveev approved these changes Jun 17, 2025

View reviewed changes

naotoj reviewed Jun 18, 2025

View reviewed changes

nizarbenalla approved these changes Jun 18, 2025

View reviewed changes

aivanov-jdk reviewed Jun 18, 2025

View reviewed changes

alisenchung added 2 commits June 18, 2025 11:40

remove double quotes

66c34e7

update to german translations

90bfd7b

sormuras reviewed Jun 24, 2025

View reviewed changes

src/demo/share/jfc/SwingSet2/resources/swingset_de.properties Outdated Show resolved Hide resolved

sormuras reviewed Jun 24, 2025

View reviewed changes

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_de.properties Outdated Show resolved Hide resolved

sormuras reviewed Jun 24, 2025

View reviewed changes

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher_de.properties Outdated Show resolved Hide resolved

wangweij reviewed Jun 24, 2025

View reviewed changes

alisenchung and others added 3 commits June 24, 2025 14:43

Update src/demo/share/jfc/SwingSet2/resources/swingset_de.properties

c5ed516

Co-authored-by: Christian Stein <[email protected]>

Update src/jdk.compiler/share/classes/com/sun/tools/javac/resources/j…

c2d1eef

…avac_de.properties Co-authored-by: Christian Stein <[email protected]>

Update src/jdk.compiler/share/classes/com/sun/tools/javac/resources/l…

97f3fe3

…auncher_de.properties Co-authored-by: Christian Stein <[email protected]>

		SliderDemo.ticks=Feinteilungen, Teilungen zum Einrasten und Labels
		SliderDemo.minorticks=Feinteilungen

		LoginModuleControlFlag.=LoginModuleControlFlag:\u0020
		LoginModuleControlFlag.=LoginModuleControlFlag：\u0020

		Subject.=Subjekt:\n
		Subject.=Subject:\n

8359761: JDK 25 RDP1 L10n resource files update #25839

Are you sure you want to change the base?

8359761: JDK 25 RDP1 L10n resource files update #25839

Uh oh!

Conversation

alisenchung commented Jun 17, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jun 17, 2025

Uh oh!

openjdk bot commented Jun 17, 2025

Uh oh!

openjdk bot commented Jun 17, 2025

Uh oh!

openjdk bot commented Jun 17, 2025

Uh oh!

openjdk bot commented Jun 17, 2025

Uh oh!

mlbridge bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

alisenchung commented Jun 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justin-curtis-lu Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sashamatveev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nizarbenalla left a comment

Choose a reason for hiding this comment

Uh oh!

jsikstro commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

alisenchung commented Jun 17, 2025 •

edited by openjdk bot

Loading

mlbridge bot commented Jun 17, 2025 •

edited

Loading

justin-curtis-lu Jun 17, 2025 •

edited

Loading

jsikstro commented Jun 18, 2025 •

edited

Loading

aivanov-jdk Jun 18, 2025 •

edited

Loading