Skip to content

8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus LookAndFeel #25907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jun 20, 2025

Issue is RadioButtonMenuItem and CheckBoxMenuItem bullet/checkmark icon is not displayed in WindowsL&F when the test is run with NimbusL&F.
This is because WindowsIconFactory#VistaMenuItemCheckIcon.paintIcon called getLaFIcon() which returns a empty NimbusIcon which causes no icons to be drawn. This is because the test after setting WIndows L&F of the menuitem reverts back the Windows L&F to Nimbus L&F via UIManager.setLookAndFeel(save); call in the test so when frame is made visible, the L&F resets back to Nimbus L&F resulting in null NimbusIcon.

Fix is made to make sure the whole frame is updated to cater to L&F change via SwingUtilities.updateComponentTreeUI(frame); call and keep the L&F without reverting back to original L&F..


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus LookAndFeel (Bug - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25907/head:pull/25907
$ git checkout pull/25907

Update a local copy of the PR:
$ git checkout pull/25907
$ git pull https://git.openjdk.org/jdk.git pull/25907/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25907

View PR using the GUI difftool:
$ git pr show -t 25907

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25907.diff

Using Webrev

Link to Webrev Comment

…entation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus LookAndFeel
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2025

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@prsadhuk
Copy link
Contributor Author

/touch

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 20, 2025
@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@prsadhuk The pull request is being re-evaluated and the inactivity timeout has been reset.

@prsadhuk
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@prsadhuk The pull request is being re-evaluated and the inactivity timeout has been reset.

@mlbridge
Copy link

mlbridge bot commented Jun 20, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant