Skip to content

8360774: Use text representation of normalization data files #26027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Jun 27, 2025

The ICU4J component currently stores binary data files directly in the repository. This change replaces them with base64-encoded text files and converts them to binary during the build process


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360774: Use text representation of normalization data files (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26027/head:pull/26027
$ git checkout pull/26027

Update a local copy of the PR:
$ git checkout pull/26027
$ git pull https://git.openjdk.org/jdk.git pull/26027/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26027

View PR using the GUI difftool:
$ git pr show -t 26027

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26027.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2025

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 27, 2025
@openjdk
Copy link

openjdk bot commented Jun 27, 2025

@naotoj The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 27, 2025

Webrevs

@magicus
Copy link
Member

magicus commented Jun 27, 2025

What is the point of this change? If the files were changed to some kind of readable text format, I would think it was a good change. Also, if this is the representation that we get from upstream, then I can understand it as well (but then a comment about it would be good).

Just converting a binary file to base64 does not accomplish anything of value. It is true that we try to avoid binary files, but if what we need actually is a binary file, then we better store it as such, rather than to taking a detour over base64.

@naotoj
Copy link
Member Author

naotoj commented Jun 27, 2025

Just converting a binary file to base64 does not accomplish anything of value. It is true that we try to avoid binary files, but if what we need actually is a binary file, then we better store it as such, rather than to taking a detour over base64.

It is merely to avoid checking binary files in the repository. If we are OK continuing to do so, I am fine with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants