-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8361827: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java throws OutOfMemoryError #26260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back rrich! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8361602_TESTBUG_UnmountedVThreadNativeMethodAtTop_OOM
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@reinrich this pull request can not be integrated into git checkout 8361602_TESTBUG_UnmountedVThreadNativeMethodAtTop_OOM
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
This pr makes sure to call System.gc() before each test in UnmountedVThreadNativeMethodAtTop.java
The intention is to get rid of unreachable objects representing loaded heap dumps from previous tests.
It prevents OutOfMemoryErrors and parsing the smaller dumps is faster.
The PR also includes a reproducer for convenient testing of the pr.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26260/head:pull/26260
$ git checkout pull/26260
Update a local copy of the PR:
$ git checkout pull/26260
$ git pull https://git.openjdk.org/jdk.git pull/26260/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26260
View PR using the GUI difftool:
$ git pr show -t 26260
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26260.diff