Skip to content

8361869: Tests which call ThreadController should mark as /native #26277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 12, 2025

Hi all,

This pull request contains a backport of commit 3bacf7ea from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 12 Jul 2025 and was reviewed by Serguei Spitsyn and Leonid Mesnik.

Test-fix only, change has been verified locally, no risk.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361869: Tests which call ThreadController should mark as /native (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26277/head:pull/26277
$ git checkout pull/26277

Update a local copy of the PR:
$ git checkout pull/26277
$ git pull https://git.openjdk.org/jdk.git pull/26277/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26277

View PR using the GUI difftool:
$ git pr show -t 26277

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26277.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 12, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361869: Tests which call ThreadController should mark as /native

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the jdk25 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3bacf7ea85f1e3f5e57fd2d046b98dfafe2c7e18 8361869: Tests which call ThreadController should mark as /native Jul 12, 2025
@openjdk
Copy link

openjdk bot commented Jul 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jul 12, 2025
@openjdk
Copy link

openjdk bot commented Jul 12, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 12, 2025

Webrevs

@jaikiran
Copy link
Member

This clean, test-only backport to jdk25 looks OK to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 17, 2025
@sendaoYan
Copy link
Member Author

This clean, test-only backport to jdk25 looks OK to me.

Thanks for the reviews @jaikiran

/integrate

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

Going to push as commit 5cc7a31.
Since your change was applied there have been 30 commits pushed to the jdk25 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2025
@openjdk openjdk bot closed this Jul 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@sendaoYan Pushed as commit 5cc7a31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated serviceability [email protected]
Development

Successfully merging this pull request may close these issues.

2 participants