Skip to content

8361602: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java deadlocks on exception #26279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

reinrich
Copy link
Member

@reinrich reinrich commented Jul 12, 2025

This pull request contains a backport of commit 917d0182 from the openjdk/jdk repository.

It moves the notify() call to the finally block to avoid the deadlock in join() if verifyHeapDump(dumpFile) throws an exception. It also wraps the wait into a loop to protect against spurious wake up.

The commit being backported was authored by Richard Reingruber on 12 Jul 2025 and was reviewed by Chris Plummer, Christoph Langer and David Holmes.

Testing was done with fastdebug and release builds on the main platforms and also on Linux/PPC64le and AIX.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361602: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java deadlocks on exception (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26279/head:pull/26279
$ git checkout pull/26279

Update a local copy of the PR:
$ git checkout pull/26279
$ git pull https://git.openjdk.org/jdk.git pull/26279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26279

View PR using the GUI difftool:
$ git pr show -t 26279

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26279.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2025

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 12, 2025

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361602: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java deadlocks on exception

Reviewed-by: clanger, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the jdk25 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 917d0182cb5ea6066afd396381ca4650371e64b0 8361602: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java deadlocks on exception Jul 12, 2025
@openjdk
Copy link

openjdk bot commented Jul 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 12, 2025
@openjdk
Copy link

openjdk bot commented Jul 12, 2025

@reinrich The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@reinrich reinrich marked this pull request as ready for review July 14, 2025 07:30
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 14, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 14, 2025
@reinrich
Copy link
Member Author

Thanks for reviewing.
/integrate

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

Going to push as commit ce85123.
Since your change was applied there have been 4 commits pushed to the jdk25 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 15, 2025
@openjdk openjdk bot closed this Jul 15, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@reinrich Pushed as commit ce85123.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated serviceability [email protected]
Development

Successfully merging this pull request may close these issues.

3 participants