8362203: assert(state == nullptr || state->get_thread_oop() != nullptr) failed: incomplete state

[lmesnik]

The problem happens if post_early_vm_start is triggered.
The fix is to complete initialization once threadObj become available.

I'vent observed that recompute_enable and hitting assertion might happens before this step. However it might be makes sense to check state in assertion if needed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362203: assert(state == nullptr || state->get_thread_oop() != nullptr) failed: incomplete state (Bug - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26303/head:pull/26303
$ git checkout pull/26303

Update a local copy of the PR:
$ git checkout pull/26303
$ git pull https://git.openjdk.org/jdk.git pull/26303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26303

View PR using the GUI difftool:
$ git pr show -t 26303

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26303.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362203: assert(state == nullptr || state->get_thread_oop() != nullptr) failed: incomplete state

Reviewed-by: sspitsyn, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• 1819051: 8362390: AIX make fails in awt_GraphicsEnv.c
• be0161a: 8362429: AssertionError in File.listFiles(FileFilter | FilenameFilter)
• bc72f47: 8362088: CompressedKlassPointers::encode should be const correct
• ... and 51 more: https://git.openjdk.org/jdk/compare/5cf672e7784b9a9a82f29977a072b162cc240fd1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lmesnik The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[lmesnik]

I renamed function just to make clear that it should be used once in startup phase.

[mlbridge]

Webrevs

• 02: Full - Incremental (739b0c1c)
• 01: Full - Incremental (a8d5e277)
• 00: Full (19e76aa9)

[sspitsyn]

This looks good in general. Thank you for catching with Kitchensink and fixing this issue!
I've posted a couple of nits.

[sspitsyn]

Thank you for updates! Looks good.

[lmesnik]

@sspitsyn, @alexmenkov Thank you for review!
/integrate

[openjdk]

Going to push as commit bd55d7a.
Since your change was applied there have been 65 commits pushed to the master branch:

• 2b11a28: 8362306: HotSpotJVMCIRuntime.getMirror can crash
• 5ed7277: 8361404: Parallel: Group all class unloading logc at the end of marking phase
• dc08cf0: 8361697: Remove duplicate message in MainResources.properties
• ... and 62 more: https://git.openjdk.org/jdk/compare/5cf672e7784b9a9a82f29977a072b162cc240fd1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit bd55d7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.