Skip to content

8358004: Delete applications/scimark/Scimark.java test #26338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 16, 2025

Hi all,

This pull request contains a backport of commit a5c9bc70 from the openjdk/jdk repository. The Scimark is not maintained, this backport PR remove this useless tests which cause test failure. Test-fix only, no risk.

The commit being backported was authored by Leonid Mesnik on 16 Jul 2025 and was reviewed by SendaoYan and Coleen Phillimore.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358004: Delete applications/scimark/Scimark.java test (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26338/head:pull/26338
$ git checkout pull/26338

Update a local copy of the PR:
$ git checkout pull/26338
$ git pull https://git.openjdk.org/jdk.git pull/26338/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26338

View PR using the GUI difftool:
$ git pr show -t 26338

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26338.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358004: Delete applications/scimark/Scimark.java test

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the jdk25 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a5c9bc70324693e9d0b25bb2c51b91dfc750c453 8358004: Delete applications/scimark/Scimark.java test Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@sendaoYan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@sendaoYan
Copy link
Member Author

/cc hotspot
/cc hotspot-runtime

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@sendaoYan
The hotspot label was successfully added.

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@sendaoYan
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 16, 2025

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 17, 2025
@sendaoYan
Copy link
Member Author

Looks good.

Thanks for the reviews. @coleenp

/integrate

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

Going to push as commit f1f6452.
Since your change was applied there have been 20 commits pushed to the jdk25 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2025
@openjdk openjdk bot closed this Jul 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@sendaoYan Pushed as commit f1f6452.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot [email protected] hotspot-runtime [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants