8358735: GenShen: bug in #undef'd code in block_start() #27353
+891
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be removed after debugging of a rare crash observed in pipeline testing.
…ock_start to aid better serviceability. Might be placed under #ifdef ASSERT to avoid perff impact in release builds.
assert under adverse conditions that the planned fix is expected to correct.
be fixed before this is ready. In particular, fails reliably with TestClone w/genshen (at least).
|
/author: ysramakrishna |
|
👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scanning a range of dirty cards within the GenShen remembered set, we need to find the object that spans the beginning of the left-most dirty card. The existing code is not reliable following class unloading.
The new code uses the marking context when it is available to determine the location of live objects that reside below TAMS within each region. Above TAMS, all objects are presumed live and parsable.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27353/head:pull/27353$ git checkout pull/27353Update a local copy of the PR:
$ git checkout pull/27353$ git pull https://git.openjdk.org/jdk.git pull/27353/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27353View PR using the GUI difftool:
$ git pr show -t 27353Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27353.diff