Skip to content

Conversation

fandreuz
Copy link
Contributor

@fandreuz fandreuz commented Sep 18, 2025

There are several usages of offset_of in vmStructs, they can be replaced with standard offsetof due to JDK-8367016.

Passes tier1.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8367984: Eliminate offset_of in vmStructs (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27362/head:pull/27362
$ git checkout pull/27362

Update a local copy of the PR:
$ git checkout pull/27362
$ git pull https://git.openjdk.org/jdk.git pull/27362/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27362

View PR using the GUI difftool:
$ git pr show -t 27362

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27362.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2025

👋 Welcome back fandreuzzi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 18, 2025

@fandreuz The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

JNIEXPORT uint64_t gHotSpotVMStructEntryIsStaticOffset = offset_of(VMStructEntry, isStatic);
JNIEXPORT uint64_t gHotSpotVMStructEntryOffsetOffset = offset_of(VMStructEntry, offset);
JNIEXPORT uint64_t gHotSpotVMStructEntryAddressOffset = offset_of(VMStructEntry, address);
extern JNIEXPORT constexpr uint64_t gHotSpotVMStructEntryTypeNameOffset = offsetof(VMStructEntry, typeName);
Copy link
Contributor Author

@fandreuz fandreuz Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a partial understanding about this change, I thought having JNIEXPORT and constexpr together wouldn't work. But the symbols are exported:

objdump --syms build/gcc/jdk/lib/server/libjvm.so | grep gHotSpotVMTypeEntryIsIntegerTypeOffset
000000000137ca78 g     O .rodata	0000000000000008              gHotSpotVMTypeEntryIsIntegerTypeOffset

and I tested that the values are still readable. I was wondering if this wouldn't be portable?

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant