Skip to content

Conversation

DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Sep 18, 2025

When looking into this, it looks like macOS does not support mnemonics. It would therefore make sense to exclude macOS from this test as its main purpose is to test mnemonics on JTabbedPanes. Updated the test header to exclude macOS and test's keyPresses to remove the macOS specific inputs.

https://discussions.apple.com/thread/7983221?sortBy=rank


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8064922: [macos] Test javax/swing/JTabbedPane/4624207/bug4624207.java fails (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27371/head:pull/27371
$ git checkout pull/27371

Update a local copy of the PR:
$ git checkout pull/27371
$ git pull https://git.openjdk.org/jdk.git pull/27371/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27371

View PR using the GUI difftool:
$ git pr show -t 27371

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27371.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2025

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 18, 2025

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added client [email protected] rfr Pull request is ready for review labels Sep 18, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2025

Webrevs

}
robot.keyPress(KeyEvent.VK_ALT);
robot.keyPress(KeyEvent.VK_B);
robot.keyRelease(KeyEvent.VK_ALT);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyRelease should be other way around...ie VK_B first and then VK_ALT

Copy link
Contributor

@prsadhuk prsadhuk Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you may want to check another test EditableFocusTest which also sets mnemonic "B" on a JButton and it passes in macOS..One difference is it uses setMnemonic(char) instead of setMnemonic(int)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants