-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8064922: [macos] Test javax/swing/JTabbedPane/4624207/bug4624207.java fails #27371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
} | ||
robot.keyPress(KeyEvent.VK_ALT); | ||
robot.keyPress(KeyEvent.VK_B); | ||
robot.keyRelease(KeyEvent.VK_ALT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyRelease should be other way around...ie VK_B first and then VK_ALT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also you may want to check another test EditableFocusTest
which also sets mnemonic "B" on a JButton and it passes in macOS..One difference is it uses setMnemonic(char) instead of setMnemonic(int)
When looking into this, it looks like macOS does not support mnemonics. It would therefore make sense to exclude macOS from this test as its main purpose is to test mnemonics on JTabbedPanes. Updated the test header to exclude macOS and test's keyPresses to remove the macOS specific inputs.
https://discussions.apple.com/thread/7983221?sortBy=rank
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27371/head:pull/27371
$ git checkout pull/27371
Update a local copy of the PR:
$ git checkout pull/27371
$ git pull https://git.openjdk.org/jdk.git pull/27371/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27371
View PR using the GUI difftool:
$ git pr show -t 27371
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27371.diff
Using Webrev
Link to Webrev Comment