8361955: [GCC static analyzer] libjdwp/threadControl.c threadControl_setPendingInterrupt error: dereference of NULL 'node'

[plummercj]

Fix gcc static analyzer warning. It was introduced by JDK-8324868 early last year. For the most part the fix is to revert the relevant JDK-8324868 changes, except for leaving in the replacement of calling findThread() with instead calling findRunningThread().

Ran all svc tier2 and tier5 tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361955: [GCC static analyzer] libjdwp/threadControl.c threadControl_setPendingInterrupt error: dereference of NULL 'node' (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27378/head:pull/27378
$ git checkout pull/27378

Update a local copy of the PR:
$ git checkout pull/27378
$ git pull https://git.openjdk.org/jdk.git pull/27378/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27378

View PR using the GUI difftool:
$ git pr show -t 27378

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27378.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361955: [GCC static analyzer] libjdwp/threadControl.c threadControl_setPendingInterrupt error: dereference of NULL 'node'

Reviewed-by: dholmes, sspitsyn, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• cc65836: 8367719: Refactor JNI code that uses class_to_verify_considering_redefinition()
• d21e73d: 8366941: Excessive logging in serviceability tests causes timeout
• b03b6f5: 8367988: NewFileSystemTests.readOnlyZipFileFailure fails when run by root user
• ... and 28 more: https://git.openjdk.org/jdk/compare/e4cb86df2b05cef6dd7e29e8803ebbbf5b4fe5a2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f95a7a1d)

[dholmes-ora]

It fixes the warning but surely impossible to be calling this function in such circumstances?

Static analyzers often lack context that would tell them something can't be null. Normally, in main hotspot code, asserts seem to do the job of telling the analyzer this.

[plummercj]

@dholmes-ora Can you read through the CR? There are more details there on why in the end I decided to go ahead and make this change.

[dholmes-ora]

@dholmes-ora Can you read through the CR? There are more details there on why in the end I decided to go ahead and make this change.

Okay I see the full story now.

[sspitsyn]

Looks reasonable.

[plummercj]

Thank you for the reviews David, Serguei, and Leonid!

/integrate

[openjdk]

Going to push as commit c3aaa87.
Since your change was applied there have been 53 commits pushed to the master branch:

• 58270b7: 8346839: [TESTBUG] "java/awt/textfield/setechochartest4/setechochartest4.java" failed because the test frame disappears on clicking "Click Several Times" button
• ced3f13: 8367901: Calendar.roll(hour, 24) returns wrong result
• 2f74e14: 8367862: debug.cpp: Do not print help message for methods ifdef'd out
• ... and 50 more: https://git.openjdk.org/jdk/compare/e4cb86df2b05cef6dd7e29e8803ebbbf5b4fe5a2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit c3aaa87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.