Skip to content

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Sep 18, 2025

On macOS mouse sensitivity setting play a role in click count increment. By increasing the double-click speed under
(Settings > Mouse Sensitivity > Double click speed), the click count no longer shows as 1,2.

image

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8017182: [macosx] MouseClickCount.java produces click count greater than 1 when left-button click is followed by quick right button click (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27379/head:pull/27379
$ git checkout pull/27379

Update a local copy of the PR:
$ git checkout pull/27379
$ git pull https://git.openjdk.org/jdk.git pull/27379/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27379

View PR using the GUI difftool:
$ git pr show -t 27379

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27379.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2025

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2025

Webrevs

2. Verify that a left-button click followed by a right button click quickly
will not generate 1, 2, i.e. it's not considered a double clicking.
""";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we automate this test?

@prrace
Copy link
Contributor

prrace commented Sep 19, 2025

What is in the description maybe misunderstanding the issue as I don't see how mouse sensitivity is related.
Look at the original bug report https://bugs.openjdk.org/browse/JDK-4199397 which describes how clicking two different buttons is interpreted as a double-click.
Apple mice do not have buttons, they have some notion of area.
I would verify this manual test only with a mouse with physical buttons.
Or better, do as suggested and automate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants