8369559: Identify owning method for MethodTrainingData and CompileTrainingData in AOT map output

[Delawen]

Provides part of fixes for: https://bugs.openjdk.org/browse/JDK-8363440
Fixes: https://bugs.openjdk.org/browse/JDK-8369559

Right now, MethodTrainingData and CompileTrainingData do not show to what Method they belong to:

$ cat aot.map | grep MethodTrainingData
0x00000008019d54c0: @@ MethodTrainingData 96
0x00000008019dcec8: @@ MethodTrainingData 96
[...]

$ cat aot.map | grep CompileTrainingData
[...]
0x000000080079c8a0: @@ CompileTrainingData 80
0x00000008007a7660: @@ CompileTrainingData 80

Add the method name to those lines in the AOT map to add more context. Also, for CompileTrainingData, add the level of compilation.

The output should look like the following:

$ cat aot.map | grep CompileTrainingData
0x000000080079c8a0: @@ CompileTrainingData 80 3 int java.lang.Byte.hashCode()
0x00000008007a7660: @@ CompileTrainingData 80 3 java.lang.Object java.lang.ref.Reference.get()
0x00000008007a76b0: @@ CompileTrainingData 80 4 java.lang.Object java.lang.ref.Reference.get()
[...]

$ cat aot.map | grep MethodTrainingData
0x00000008007864c0: @@ MethodTrainingData 96 void java.lang.System.arraycopy(java.lang.Object, int, java.lang.Object, int, int)
0x00000008007884f0: @@ MethodTrainingData 96 boolean java.lang.Module.isNamed()
0x00000008007892f8: @@ MethodTrainingData 96 boolean java.lang.Module.implIsExportedOrOpen(java.lang.String, java.lang.Module, boolean)
[...]

Note the number before the method signature on CompileTrainingData that represents the level, important because there are two CompileTrainingData for the same method with different compilation levels.

Some elements have a nullpointer instead of a valid Method, and those will be represented without method signature (as they appear currently, with no changes).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8369559: Identify owning method for MethodTrainingData and CompileTrainingData in AOT map output (Sub-task - P4)

Reviewers

• Andrew Dinn (@adinn - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27740/head:pull/27740
$ git checkout pull/27740

Update a local copy of the PR:
$ git checkout pull/27740
$ git pull https://git.openjdk.org/jdk.git pull/27740/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27740

View PR using the GUI difftool:
$ git pr show -t 27740

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27740.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Delawen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Delawen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369559: Identify owning method for MethodTrainingData and CompileTrainingData in AOT map output

Reviewed-by: adinn, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 42b2999: 8369812: HttpClient doesn't handle H3_REQUEST_REJECTED correctly
• c82c892: 8282427: jdk/jfr/jvm/TestWaste.java is failing with "exit code 139"
• 3d95c83: 8358597: [asan] Buffer overflow in ArchiveBuilder::make_shallow_copy with Symbols
• ... and 50 more: https://git.openjdk.org/jdk/compare/f52aed6f81e7df9ab9a379ada952b8e666c54e6d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@adinn, @iklam) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@Delawen The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (de83ccbb)

[Delawen]

@adinn @iklam can you please review this one too? More log messages on the AOT Map file.

[adinn]

Looks ok to me.

[iklam]

Looks good.

[Delawen]

/integrate

[openjdk]

@Delawen
Your change (at version de83ccb) is now ready to be sponsored by a Committer.

[adinn]

/sponsor

[openjdk]

Going to push as commit 355cb45.
Since your change was applied there have been 53 commits pushed to the master branch:

• 42b2999: 8369812: HttpClient doesn't handle H3_REQUEST_REJECTED correctly
• c82c892: 8282427: jdk/jfr/jvm/TestWaste.java is failing with "exit code 139"
• 3d95c83: 8358597: [asan] Buffer overflow in ArchiveBuilder::make_shallow_copy with Symbols
• ... and 50 more: https://git.openjdk.org/jdk/compare/f52aed6f81e7df9ab9a379ada952b8e666c54e6d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@adinn @Delawen Pushed as commit 355cb45.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.