8369305: Adjust usage of CDS in the boot JDK

[MBaesken]

Currently we dump an archive in the configure process, this might not be needed/beneficial any more.

Building with and without the change on Linux x86_64 (product) shows similar build times.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8369305: Adjust usage of CDS in the boot JDK (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27741/head:pull/27741
$ git checkout pull/27741

Update a local copy of the PR:
$ git checkout pull/27741
$ git pull https://git.openjdk.org/jdk.git pull/27741/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27741

View PR using the GUI difftool:
$ git pr show -t 27741

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27741.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369305: Adjust usage of CDS in the boot JDK

Reviewed-by: erikj, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 4496418: 8365205: C2: Optimize popcount value computation using knownbits
• d6ca382: 8369335: Two sun/java2d/OpenGL tests fail on Windows after JDK-8358058
• 4ca4485: 8365588: defineClass that accepts a ByteBuffer does not work as expected
• ... and 31 more: https://git.openjdk.org/jdk/compare/b00720edd72226ae9ffecbcb9c1062d3ceb8c6df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (ead36703)
• 01: Full - Incremental (5002d9fe)
• 00: Full (9c513c97)

[MBaesken]

Should we remove this too ?

autoconf/bootcycle-spec.gmk.template-47-# Any CDS settings generated for the bootjdk are invalid in the bootcycle build.
autoconf/bootcycle-spec.gmk.template-48-# By filtering out those JVM args, the bootcycle JVM will use its default
autoconf/bootcycle-spec.gmk.template-49-# settings for CDS.
autoconf/bootcycle-spec.gmk.template:50:JAVA_FLAGS := $(filter-out -XX:SharedArchiveFile% -Xshare%, $(JAVA_FLAGS))

[erikj79]

Should we remove this too ?

autoconf/bootcycle-spec.gmk.template-47-# Any CDS settings generated for the bootjdk are invalid in the bootcycle build.
autoconf/bootcycle-spec.gmk.template-48-# By filtering out those JVM args, the bootcycle JVM will use its default
autoconf/bootcycle-spec.gmk.template-49-# settings for CDS.
autoconf/bootcycle-spec.gmk.template:50:JAVA_FLAGS := $(filter-out -XX:SharedArchiveFile% -Xshare%, $(JAVA_FLAGS))

Yes.

[MBaesken]

Should we remove this too ?

autoconf/bootcycle-spec.gmk.template-47-# Any CDS settings generated for the bootjdk are invalid in the bootcycle build.
autoconf/bootcycle-spec.gmk.template-48-# By filtering out those JVM args, the bootcycle JVM will use its default
autoconf/bootcycle-spec.gmk.template-49-# settings for CDS.
autoconf/bootcycle-spec.gmk.template:50:JAVA_FLAGS := $(filter-out -XX:SharedArchiveFile% -Xshare%, $(JAVA_FLAGS))

Yes.

Done!

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit a3ee821.
Since your change was applied there have been 37 commits pushed to the master branch:

• 2eb0898: 8367157: Remove jrunscript tool
• 5bf1bab: 8369482: JVMTI + Loom: JDK-8368159 introduced safepoint poll in disallowed state
• be0e49b: 8369467: Rdtsc: Remove experimental support for non invariant tsc
• ... and 34 more: https://git.openjdk.org/jdk/compare/b00720edd72226ae9ffecbcb9c1062d3ceb8c6df...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit a3ee821.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.