Skip to content

8369511: PPC64: compiler/vectorapi/VectorMaskCompareNotTest.java fails when running without VectorRegisters #27749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8369511: PPC64: compiler/vectorapi/VectorMaskCompareNotTest.java fails when running without VectorRegisters #27749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@
* @library /test/lib /
* @summary test combining vector not operation with compare
* @modules jdk.incubator.vector
* @requires (os.arch != "riscv64" | (os.arch == "riscv64" & vm.cpu.features ~= ".*rvv.*"))
* @requires (os.arch != "riscv64" & os.arch != "ppc64" & os.arch != "ppc64le") |
* (os.arch == "riscv64" & vm.cpu.features ~= ".*rvv.*") |
* ((os.arch == "ppc64" | os.arch == "ppc64le") & vm.cpu.features ~= ".*darn.*")
Comment on lines +38 to +40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by comment:

This is getting more convoluted now. I think it would make sense to at least document why we are skipping it for all the platforms.

You should also state the reason for the change in the PR description as well as on JIRA ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an alternative solution: #27805
Please take a look.

*
* @run driver compiler.vectorapi.VectorMaskCompareNotTest
*/
Expand Down