Skip to content

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Oct 10, 2025

The first test case in H3MalformedResponseTest is still intermittently failing with TimeoutException, even after #27447. This PR removes the unnecessary per-request time limit.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369593: Test H3MalformedResponseTest.testMalformedResponse still times out (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27752/head:pull/27752
$ git checkout pull/27752

Update a local copy of the PR:
$ git checkout pull/27752
$ git pull https://git.openjdk.org/jdk.git pull/27752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27752

View PR using the GUI difftool:
$ git pr show -t 27752

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27752.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2025

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369593: Test H3MalformedResponseTest.testMalformedResponse still times out

Reviewed-by: jpai, vyazici, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8369593 8369593: Test H3MalformedResponseTest.testMalformedResponse still times out Oct 10, 2025
@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@djelinski The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 10, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2025

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2025
Copy link
Contributor

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had approved this 3 weeks ago. 😎

@djelinski
Copy link
Member Author

Thanks @jaikiran @vy @dfuch for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2025

Going to push as commit 6d1529c.
Since your change was applied there have been 89 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2025
@openjdk openjdk bot closed this Oct 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2025
@openjdk
Copy link

openjdk bot commented Oct 14, 2025

@djelinski Pushed as commit 6d1529c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@djelinski djelinski deleted the h3malformed-timeout branch October 14, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated net [email protected]

Development

Successfully merging this pull request may close these issues.

4 participants