8368205: [TESTBUG] VectorMaskCompareNotTest.java crashes when MaxVectorSize=8 #27805

TheRealMDoerr · 2025-10-14T18:21:45Z

The test VectorMaskCompareNotTest requires 16 Byte vectors (or larger). If the machine only uses 8 Byte vectors, we get an exception in the static initializer because the code tries to use a 4 Byte vector which is unsupported (stack trace: see JBS issue JDK-8369511). This is an alternative to #27749.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8368205: [TESTBUG] VectorMaskCompareNotTest.java crashes when MaxVectorSize=8 (Bug - P4)

Reviewers

Richard Reingruber (@reinrich - Reviewer) Review applies to 3041e656
Dingli Zhang (@DingliZhang - Author)
Emanuel Peter (@eme64 - Reviewer)

Reviewers without OpenJDK IDs

@erifan (no known openjdk.org user name / role) Review applies to 3041e656

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27805/head:pull/27805
$ git checkout pull/27805

Update a local copy of the PR:
$ git checkout pull/27805
$ git pull https://git.openjdk.org/jdk.git pull/27805/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27805

View PR using the GUI difftool:
$ git pr show -t 27805

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27805.diff

Using Webrev

Link to Webrev Comment

…s when running without VectorRegisters

bridgekeeper · 2025-10-14T18:23:23Z

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-10-14T18:24:42Z

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368205: [TESTBUG] VectorMaskCompareNotTest.java crashes when MaxVectorSize=8

Reviewed-by: dzhang, epeter, rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

aa194c6: 8369881: C2: Unexpected node in SuperWord truncation: ReverseBytesS, ReverseBytesUS
5696d60: 8357809: Test jdk/jshell/JdiListeningExecutionControlTest.java failed with com.sun.jdi.connect.TransportTimeoutException
0168687: 8368940: Missing ResourceMark when stalling for shutdown
... and 27 more: https://git.openjdk.org/jdk/compare/4b85ba90671c0ac816a772584c3eeb30ef9062ba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-10-14T18:25:42Z

@TheRealMDoerr The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-10-14T18:29:05Z

Webrevs

01: Full - Incremental (4af2585a)
00: Full (3041e656)

eme64 · 2025-10-15T05:43:02Z

@TheRealMDoerr I think I prefer this solution 😊

Though I wonder if we need to add some kind of label for the jtreg changes? I'm not familiar with the code there.
But I can surely approve the test changes :)

reinrich

I think this is a good and easy to understand solution.

eme64 · 2025-10-15T08:14:49Z

@TheRealMDoerr I'll approve after some internal sanity testing :)

TheRealMDoerr · 2025-10-15T08:31:54Z

@DingliZhang, @RealFYang: Can one of you please check if this is also fine for RISC-V, please?

erifan

LGTM, thanks for taking care of the issue!

TheRealMDoerr · 2025-10-15T12:33:44Z

@erifan: Thanks for the review! I've added a check if the flag is available similar to what you had in your PR. That may be needed for VM configurations without C2 compiler.

DingliZhang

Hi @TheRealMDoerr Thanks for the patch! I’ve tested VectorMaskCompareNotTest.java on k1 and k230 (with RVV) as well as sg2042 (without RVV), and it looks good.

eme64

Looks reasonable. Sanity testing for commit 1 passed.

TheRealMDoerr · 2025-10-16T09:38:49Z

Thank you for all the reviews and for testing!
/integrate

openjdk · 2025-10-16T09:40:56Z

Going to push as commit 6e911d8.
Since your change was applied there have been 35 commits pushed to the master branch:

b5b8324: 8369656: Calling CompletableFuture.join() could execute task in common pool
17c13e5: 8369683: Exclude runtime/Monitor/MonitorWithDeadObjectTest.java#DumpThreadsBeforeDetach on Alpine Linux debug
ff6a017: 8369258: C2: enable ReassociateInvariants for all loop types
... and 32 more: https://git.openjdk.org/jdk/compare/4b85ba90671c0ac816a772584c3eeb30ef9062ba...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-10-16T09:41:15Z

@TheRealMDoerr Pushed as commit 6e911d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

erifan · 2025-10-16T10:27:13Z

@TheRealMDoerr Please consider whether my comment is reasonable. Also, @eme64 tested your commit 1, but then you pushed commit 2. So commit 1 is no longer the latest code. Although I think commit 2 will likely pass the test as well.

erifan · 2025-10-16T03:09:24Z

test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java

 * @summary test combining vector not operation with compare
 * @modules jdk.incubator.vector
- * @requires (os.arch != "riscv64" | (os.arch == "riscv64" & vm.cpu.features ~= ".*rvv.*"))
+ * @requires vm.opt.final.MaxVectorSize == "null" | vm.opt.final.MaxVectorSize >= 16


Should be

Suggested change

* @requires vm.opt.final.MaxVectorSize == "null" | vm.opt.final.MaxVectorSize >= 16

* @requires vm.opt.final.MaxVectorSize == "null" & vm.opt.final.MaxVectorSize >= 16

or

Suggested change

* @requires vm.opt.final.MaxVectorSize == "null" | vm.opt.final.MaxVectorSize >= 16

* @requires vm.compiler2.enabled & vm.opt.final.MaxVectorSize >= 16

?

Assume this test is run with another compiler (like Graal) that doesn't support the option MaxVectorSize, then vm.opt.final.MaxVectorSize == "null" holds. But this can't guarantee that the max vector size >= 16.

I forgot to submit this comment. I thought I submitted it two days ago.

I thought someone may want to run the test in a configuration without C2. So, I didn't want to change the test for such cases. I leave such decisions to others. Maybe @dougxc has an opinion about Graal?

Maybe they just need to put their own guards there if they care? It's hard to guard this very generically.

I thought someone may want to run the test in a configuration without C2.

Yeah I know your point. But vm.opt.final.MaxVectorSize == "null" doesn't work I think, because this doesn't guarantee the max vector size >= 16. Perhaps as @eme64 pointed out, it is hard for us to ensure that all compilers work. This do no harm to C2 test, just a bit unnecessary.

8369511: PPC64: compiler/vectorapi/VectorMaskCompareNotTest.java fail…

3041e65

…s when running without VectorRegisters

TheRealMDoerr mentioned this pull request Oct 14, 2025

8369511: PPC64: compiler/vectorapi/VectorMaskCompareNotTest.java fails when running without VectorRegisters #27749

Closed

3 tasks

openjdk bot added the hotspot-compiler [email protected] label Oct 14, 2025

openjdk bot added the rfr Pull request is ready for review label Oct 14, 2025

dean-long mentioned this pull request Oct 15, 2025

8368205: [TESTBUG] VectorMaskCompareNotTest.java crashes when MaxVectorSize=8 #27418

Closed

3 tasks

reinrich approved these changes Oct 15, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 15, 2025

TheRealMDoerr changed the title ~~8369511: PPC64: compiler/vectorapi/VectorMaskCompareNotTest.java fails when running without VectorRegisters~~ 8368205: [TESTBUG] VectorMaskCompareNotTest.java crashes when MaxVectorSize=8 Oct 15, 2025

erifan approved these changes Oct 15, 2025

View reviewed changes

Add check if flag is available.

4af2585

openjdk bot removed the ready Pull request is ready to be integrated label Oct 15, 2025

DingliZhang approved these changes Oct 16, 2025

View reviewed changes

eme64 approved these changes Oct 16, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 16, 2025

openjdk bot added the integrated Pull request has been integrated label Oct 16, 2025

openjdk bot closed this Oct 16, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2025

erifan reviewed Oct 17, 2025

View reviewed changes

TheRealMDoerr deleted the 8369511_VectorMaskCompareNotTest_noVSX_v2 branch October 17, 2025 08:24

	* @requires vm.opt.final.MaxVectorSize == "null" \| vm.opt.final.MaxVectorSize >= 16
	* @requires vm.opt.final.MaxVectorSize == "null" & vm.opt.final.MaxVectorSize >= 16

	* @requires vm.opt.final.MaxVectorSize == "null" \| vm.opt.final.MaxVectorSize >= 16
	* @requires vm.compiler2.enabled & vm.opt.final.MaxVectorSize >= 16

8368205: [TESTBUG] VectorMaskCompareNotTest.java crashes when MaxVectorSize=8 #27805

8368205: [TESTBUG] VectorMaskCompareNotTest.java crashes when MaxVectorSize=8 #27805

Uh oh!

Conversation

TheRealMDoerr commented Oct 14, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewers without OpenJDK IDs

Reviewing

Uh oh!

bridgekeeper bot commented Oct 14, 2025

Uh oh!

openjdk bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

eme64 commented Oct 15, 2025

Uh oh!

reinrich left a comment

Choose a reason for hiding this comment

Uh oh!

eme64 commented Oct 15, 2025

Uh oh!

TheRealMDoerr commented Oct 15, 2025

Uh oh!

erifan left a comment

Choose a reason for hiding this comment

Uh oh!

TheRealMDoerr commented Oct 15, 2025

Uh oh!

DingliZhang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eme64 left a comment

Choose a reason for hiding this comment

Uh oh!

TheRealMDoerr commented Oct 16, 2025

Uh oh!

openjdk bot commented Oct 16, 2025

Uh oh!

openjdk bot commented Oct 16, 2025

Uh oh!

erifan commented Oct 16, 2025

Uh oh!

erifan Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

erifan Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

TheRealMDoerr Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

eme64 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

erifan Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

TheRealMDoerr commented Oct 14, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Oct 14, 2025 •

edited

Loading

openjdk bot commented Oct 14, 2025 •

edited

Loading

mlbridge bot commented Oct 14, 2025 •

edited

Loading

DingliZhang left a comment •

edited

Loading