8369946: Bytecode rewriting causes Java heap corruption on PPC

[TheRealMDoerr]

Like the aarch64 fix (#27748).
PPC64 has additional requirements:

• It implements fast_invokevfinal which uses ResolvedMethodEntry.
• Speculative loads need to get prevented by memory barrier instructions (even on control dependent paths).

I've refactored load_field_entry and load_method_entry into a common function and added support for rewritten "fast" Bytecodes. I'm using isync instructions because we already have a control dependency (via Bytecode dispatch).

The isync instruction is relatively cheap in comparison to other memory barriers, but still introduces some performance loss. SPEC jvm98 with -Xint shows about 5% regression in compress sub-benchmark. The other sub-benchmarks are not significantly impacted. However, switching off RewriteBytecodes would cause a much higher performance loss.

Note: I had also ported the verify_field_offset check and used it in the fastdebug and product build for testing, but couldn't catch any issue. Not included in this PR. I'm not planning to contribute it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8369946: Bytecode rewriting causes Java heap corruption on PPC (Bug - P2)

Reviewers

• Richard Reingruber (@reinrich - Reviewer)
• David Briemann (@dbriemann - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27867/head:pull/27867
$ git checkout pull/27867

Update a local copy of the PR:
$ git checkout pull/27867
$ git pull https://git.openjdk.org/jdk.git pull/27867/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27867

View PR using the GUI difftool:
$ git pr show -t 27867

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27867.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369946: Bytecode rewriting causes Java heap corruption on PPC

Reviewed-by: rrich, dbriemann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• 0529a58: 8370326: Parallel: Remove unused ParCompactionManager::push
• 2af4d20: 8370031: Make RegMask copy constructor explicit and replace RegMask operator= with named function
• 517d543: 8370234: Remove CardTableBarrierSet::write_region
• ... and 47 more: https://git.openjdk.org/jdk/compare/e62a7fa3832bbba11e6d630015f85ae945fac824...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@TheRealMDoerr The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (773b82f2)
• 00: Full (138df669)

[reinrich]

Hi Martin,
nasty bug this is. Thanks for doing the fixing on ppc. And great work by Justin finding it!
I see that we've missed porting previous fixes to ppc that prevent reordering of the bytecode load with loads from ResolvedFieldEntry and -MethodEntry (JDK-8248219 and JDK-8327647). Now this is done in load_field_or_method_entry().
The change is good. The comment could be improved a little bit.
Thanks, Richard.

[TheRealMDoerr]

Thanks for the reviews! I'll start working on backports.
/integrate

[openjdk]

Going to push as commit 6bf3581.
Since your change was applied there have been 67 commits pushed to the master branch:

• 27c83c7: 8370225: RISC-V: cleanup verify_xxx in interp_masm_riscv.hpp
• 8d9b2fa: 8365072: Refactor tests to use PEM API (Phase 2)
• eff4b11: 8369322: Implement native stack printing for Windows-AArch64
• ... and 64 more: https://git.openjdk.org/jdk/compare/e62a7fa3832bbba11e6d630015f85ae945fac824...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 6bf3581.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.