8371121: compiler/whitebox/DeoptimizeRelocatedNMethod.java fails with C1

[chadrako]

JDK-8371121

This update aims to improve the test’s stability. A previous failure occurred because the method wasn’t compiled at the time of the check. I believe this could have occurred due to a deoptimization but I have not been able to reproduce. Previously, the test ensured compilation by repeatedly invoking the function. Instead, we now use Whitebox to add the method directly to the compile queue and wait for it to finish compiling. This approach should eliminate issues caused by deoptimization from function calls.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371121: compiler/whitebox/DeoptimizeRelocatedNMethod.java fails with C1 (Bug - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28246/head:pull/28246
$ git checkout pull/28246

Update a local copy of the PR:
$ git checkout pull/28246
$ git pull https://git.openjdk.org/jdk.git pull/28246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28246

View PR using the GUI difftool:
$ git pr show -t 28246

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28246.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chadrako! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chadrako This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371121: compiler/whitebox/DeoptimizeRelocatedNMethod.java fails with C1

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 143 new commits pushed to the master branch:

• 5f42c77: 8370839: Tests to verify peculiar Proxy dispatching behaviors
• b6ba1ac: 8371093: Assert "section header string table should be loaded" failed on debug VM
• 676e6fd: 8367292: VectorAPI: Optimize VectorMask.fromLong/toLong() for SVE
• ... and 140 more: https://git.openjdk.org/jdk/compare/9f972008ff2beb4b69855f4c42b8a664a6b8bc95...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@chadrako The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8d761d15)

[TobiHartmann]

That looks good to me.