Skip to content

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Nov 12, 2025

Please review this update to the gcc/clang link-time check to prevent HotSpot
code from using the C++ global allocator. A number of overloads for allocation
and deallocation functions have been added since C++03 and were missing from
the list being checked for.

Testing: mach5 tier1, GHA sanity tests (in progress)

Locally (linux-aarch64) added uses of some of these functions and verified
they caused the expected link-time failures. Manually verified applying
c++filt to all the names in the updated list demangle to the expected function
names.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369188: Update link-time check for HotSpot uses of allocation and deallocation functions (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28253/head:pull/28253
$ git checkout pull/28253

Update a local copy of the PR:
$ git checkout pull/28253
$ git pull https://git.openjdk.org/jdk.git pull/28253/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28253

View PR using the GUI difftool:
$ git pr show -t 28253

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28253.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@kimbarrett The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@kimbarrett kimbarrett marked this pull request as ready for review November 12, 2025 08:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2025

Webrevs

Copy link
Contributor

@TheShermanTanker TheShermanTanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants