8042054: JTree.updateUI uses out-of-date item size information #28258
+103
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JTree.updateUIcalculate item sizes from the cell renderer, but it doesn't callupdateUIon the cell renderer until afterwards. This leads to incorrect size calculation, which is observed when we switch from one L&F to another where it is seen that all tree items are slightly too cramped, with too little space between rows and text are abbreviated.Fix is to ensure
JTree.updateUIupdate the cell renderer before updating the UI.CI testing is ok..
Before fix

After fix

Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28258/head:pull/28258$ git checkout pull/28258Update a local copy of the PR:
$ git checkout pull/28258$ git pull https://git.openjdk.org/jdk.git pull/28258/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28258View PR using the GUI difftool:
$ git pr show -t 28258Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28258.diff
Using Webrev
Link to Webrev Comment