Skip to content

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Nov 12, 2025

Revise heap/old-gen expansion asserts/comments to cover two paths:

  1. startup: no gc can occur
  2. after-startup: during safepoint, by vm-thread.

Test: tier1-4


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371465: Parallel: Revise asserts around heap expansion (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28266/head:pull/28266
$ git checkout pull/28266

Update a local copy of the PR:
$ git checkout pull/28266
$ git pull https://git.openjdk.org/jdk.git pull/28266/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28266

View PR using the GUI difftool:
$ git pr show -t 28266

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28266.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8371465 8371465: Parallel: Revise asserts around heap expansion Nov 12, 2025
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant