Skip to content

8301753: AppendFile/WriteFile has differences between make 3.81 and 4+ #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wkia
Copy link

@wkia wkia commented Nov 22, 2024

Clean backport to 11u.
This fixes "make test" build problem occured with make version <4.0 in JDK11.
The new test is passed locally with a manual run with both "GNU Make 3.82" and "GNU Make 4.3".


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301753 needs maintainer approval

Issue

  • JDK-8301753: AppendFile/WriteFile has differences between make 3.81 and 4+ (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2969/head:pull/2969
$ git checkout pull/2969

Update a local copy of the PR:
$ git checkout pull/2969
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2969/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2969

View PR using the GUI difftool:
$ git pr show -t 2969

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2969.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2024

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@wkia This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301753: AppendFile/WriteFile has differences between make 3.81 and 4+

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport a39cf2e3b242298fbf5fafdb8aa9b5d4562061ef 8301753: AppendFile/WriteFile has differences between make 3.81 and 4+ Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2024

Webrevs

@wkia
Copy link
Author

wkia commented Nov 22, 2024

/approval 8301753 request Clean backport to 11u. This fixes "make run-test-prebuilt" build problem occured with make version <4.0 in JDK11.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@wkia
8301753: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 22, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2024

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2025

@wkia This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jan 17, 2025
@wkia
Copy link
Author

wkia commented Jan 28, 2025

/open

@openjdk openjdk bot reopened this Jan 28, 2025
@openjdk
Copy link

openjdk bot commented Jan 28, 2025

@wkia This pull request is now open

@openjdk openjdk bot removed the approval label Feb 20, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2025

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2025

@wkia This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Mar 25, 2025
@wkia
Copy link
Author

wkia commented Mar 26, 2025

/open

@openjdk openjdk bot reopened this Mar 26, 2025
@openjdk
Copy link

openjdk bot commented Mar 26, 2025

@wkia This pull request is now open

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 7, 2025
@wkia
Copy link
Author

wkia commented Apr 7, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@wkia
Your change (at version f1edf17) is now ready to be sponsored by a Committer.

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2025

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@wkia
Copy link
Author

wkia commented May 6, 2025

Up

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed clean and fix looks good.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 8, 2025

Going to push as commit 0df5d27.
Since your change was applied there have been 69 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 8, 2025
@openjdk openjdk bot closed this May 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 8, 2025
@openjdk
Copy link

openjdk bot commented May 8, 2025

@gnu-andrew @wkia Pushed as commit 0df5d27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants