Skip to content

8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dtmhuang
Copy link

@dtmhuang dtmhuang commented May 28, 2025

Backport for ShenandoahLock performance regression issue. The fix involves sleeping for a very short duration every 3 yields, with the number of yields picked through manual testing.

Clean backport, ran GHA sanity checks and locally tested tier1, tier2, and hotspot_gc_shenandoah. test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java sometimes fails locally, but it also sometimes failed before the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8350285 needs maintainer approval

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3614/head:pull/3614
$ git checkout pull/3614

Update a local copy of the PR:
$ git checkout pull/3614
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3614

View PR using the GUI difftool:
$ git pr show -t 3614

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3614.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label May 28, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2025

Hi @dtmhuang, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dtmhuang" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented May 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport bd8ad309b59bceb3073a8d6411cca74e73508885 8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention May 28, 2025
@openjdk
Copy link

openjdk bot commented May 28, 2025

This backport pull request has now been updated with issue from the original commit.

@dtmhuang
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label May 28, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@dtmhuang dtmhuang marked this pull request as ready for review May 29, 2025 23:14
@shipilev
Copy link
Member

shipilev commented Jun 2, 2025

Just to make sure, @robilad: @dtmhuang is from Amazon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

2 participants