8339725: Concurrent GC crashed due to GetMethodDeclaringClass

[fandreuz]

Backport JDK-8339725. Applies almost cleanly. Fixes a crash in concurrent GC due to GetMethodDeclaringClass.

I ran the reproducer against jdk17, and I confirm that the crash applies to this version too.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8339725 needs maintainer approval

Issue

• JDK-8339725: Concurrent GC crashed due to GetMethodDeclaringClass (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3646/head:pull/3646
$ git checkout pull/3646

Update a local copy of the PR:
$ git checkout pull/3646
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3646/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3646

View PR using the GUI difftool:
$ git pr show -t 3646

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3646.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339725: Concurrent GC crashed due to GetMethodDeclaringClass

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• fb0a796: 8315505: CompileTask timestamp printed can overflow
• 183b9a0: 8314978: Multiple server call from connection failing with expect100 in getOutputStream
• 2a9bba2: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/cd08601f2036d92427caec7eac96cea16ddcbbba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (45f2eb42)
• 00: Full (2f06247b)

[openjdk]

⚠️ @fandreuz This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[fandreuz]

/approval request Fixes JDK-8339725. Solves a crash during concurrent GC after a call to GetMethodDeclaringClass.

[openjdk]

@fandreuz
8339725: The approval request has been created successfully.

[GoeLin]

Hi @fandreuz
Please be a bit more elaborate in your fix-request comment. See also
https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

[fandreuz]

/approval request Fixes JDK-8339725. Applies almost cleanly, except for small changes required in test makefiles. Passes tier 1 test suite. This backport solves a crash in concurrent GC after a call to GetMethodDeclaringClass. I confirm that the newly introduced test fails on master and is fixed with this backport.

[fandreuz]

Hi @GoeLin, thank you for the feedback. I amended my approval request

[openjdk]

@fandreuz
8339725: The approval request has been updated successfully.

[GoeLin]

Hi @fandreuz
please enable Github actions and merge head to run the tests on this PR