8301255: Http2Connection may send too many GOAWAY frames #3686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I backport this for parity with 17.0.17-oracle.
Omitted copyrights as files already have younger ones.
Resolved two chunks in Http2Connection because later change
"8328286: Enhance HTTP client" was already backported.
In shutdown(Throwable) that change added line
cause.compareAndSet(null, t);
messing up the context.
Also, it removed the line
if (initialCause == null) this.cause = t;
this change intends to edit, so I omitted this edit.
In protocolError(int, String) "8328286: Enhance HTTP client" added some
code that needs to go into the if() added by this change.
Resolved. so that it is the same as in 21.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3686/head:pull/3686
$ git checkout pull/3686
Update a local copy of the PR:
$ git checkout pull/3686
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3686/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3686
View PR using the GUI difftool:
$ git pr show -t 3686
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3686.diff
Using Webrev
Link to Webrev Comment