Skip to content

8301255: Http2Connection may send too many GOAWAY frames #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 27, 2025

I backport this for parity with 17.0.17-oracle.

Omitted copyrights as files already have younger ones.

Resolved two chunks in Http2Connection because later change
"8328286: Enhance HTTP client" was already backported.

In shutdown(Throwable) that change added line
cause.compareAndSet(null, t);
messing up the context.
Also, it removed the line
if (initialCause == null) this.cause = t;
this change intends to edit, so I omitted this edit.

In protocolError(int, String) "8328286: Enhance HTTP client" added some
code that needs to go into the if() added by this change.
Resolved. so that it is the same as in 21.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301255 needs maintainer approval

Issue

  • JDK-8301255: Http2Connection may send too many GOAWAY frames (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3686/head:pull/3686
$ git checkout pull/3686

Update a local copy of the PR:
$ git checkout pull/3686
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3686

View PR using the GUI difftool:
$ git pr show -t 3686

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3686.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 041a12e65530b5832b4a500180c97a2a60e0dc51 8301255: Http2Connection may send too many GOAWAY frames Jun 27, 2025
@openjdk
Copy link

openjdk bot commented Jun 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 27, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 27, 2025

GAH failure: download failed. Unrelated.
jdk-17.0.17/fastdebug/lib/modules: truncated gzip input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant