Skip to content

8341964: Add mechanism to disable different parts of TLS cipher suite #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 19, 2025

I backport this for parity with 17.0.17-oracle

I assume it was backportet there. There is a CSR for 17, and follow up JDK-8349583 was backported there.

src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java
Resolved imports.

test/jdk/sun/security/ssl/CipherSuite/NoDesRC4DesEdeCiphSuite.java
This file was added by https://bugs.openjdk.org/browse/JDK-8163327 in 19. Omitted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8343623 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8341964 needs maintainer approval

Issues

  • JDK-8341964: Add mechanism to disable different parts of TLS cipher suite (Enhancement - P3 - Approved)
  • JDK-8343623: Add mechanism to disable different parts of TLS cipher suite (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3775/head:pull/3775
$ git checkout pull/3775

Update a local copy of the PR:
$ git checkout pull/3775
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3775/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3775

View PR using the GUI difftool:
$ git pr show -t 3775

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3775.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 19, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341964: Add mechanism to disable different parts of TLS cipher suite

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 697f27c5d53dbe275685b87c8ed1bcfe4da6e4d0 8341964: Add mechanism to disable different parts of TLS cipher suite Jul 19, 2025
@openjdk
Copy link

openjdk bot commented Jul 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 19, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 19, 2025

Webrevs

@MBaesken
Copy link
Member

Looks okay , but the non existing test has the name NoDesRC4CiphSuite in jdk17 (was moved to a new name NoDesRC4DesEdeCiphSuite in 19) ; have you checked for potential need of adjusting this test ?

@GoeLin
Copy link
Member Author

GoeLin commented Jul 21, 2025

Hi @MBaesken
Yes, the change can be applied to that test nicely.
It basically refactors code to superclass that is reused by the new tests.
Unclear whether it makes a difference for later backports.
I pushed an extra change with it, test passes.

@openjdk
Copy link

openjdk bot commented Jul 23, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 24, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Jul 29, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 29, 2025

Going to push as commit c90978b.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 29, 2025
@openjdk openjdk bot closed this Jul 29, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 29, 2025
@openjdk
Copy link

openjdk bot commented Jul 29, 2025

@GoeLin Pushed as commit c90978b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8341964 branch July 29, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants