8333867: SHA3 performance can be improved

[dchuyko]

This is a clean backport of multi-platform SHA3 performance improvement. MessageDigests benchmarks show same speedup as for the original change (C2 generated code variant, -XX:-UseSHA3Intrinsics).

Testing: test/jdk/sun/security, tier1, tier2 (linux-aarch64, linux-amd64).

---

Progress

• Change must not contain extraneous whitespace
• JDK-8333867 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8333867: SHA3 performance can be improved (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1000/head:pull/1000
$ git checkout pull/1000

Update a local copy of the PR:
$ git checkout pull/1000
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1000/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1000

View PR using the GUI difftool:
$ git pr show -t 1000

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1000.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @dchuyko This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (a5b3e4f1)

[dchuyko]

/approval request This is a clean backport of multi-platform SHA3 performance improvement. MessageDigests benchmarks show same C2 generated code speedup as for the original change. E.g. +25% on Graviton 2 on long arrays.

The patch removes unnecessary conversions between byte arrays and long arrays without changing the computation algorithm, only code related to SHA3 is modified, except the single private->protected blockSize change in DigestBase.

Testing: test/jdk/sun/security, tier1, tier2.

[openjdk]

@dchuyko
8333867: The approval request has been created successfully.

[jerboaa]

@dchuyko Please get this into a JDK 23 release (latest active STS), before proposing for JDK 21.

[bridgekeeper]

@dchuyko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!