Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340418: GHA: MacOS AArch64 bundles can be removed prematurely #1003

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 23, 2024

Clean backport to improve GHA reliability. Follows JDK-8325194.

Additional testing:

  • GHA

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340418 needs maintainer approval

Issue

  • JDK-8340418: GHA: MacOS AArch64 bundles can be removed prematurely (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1003/head:pull/1003
$ git checkout pull/1003

Update a local copy of the PR:
$ git checkout pull/1003
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1003/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1003

View PR using the GUI difftool:
$ git pr show -t 1003

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1003.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340418: GHA: MacOS AArch64 bundles can be removed prematurely

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9d76c7c60ff3133c1078892d7c50a2cfc9ff9c1b 8340418: GHA: MacOS AArch64 bundles can be removed prematurely Sep 23, 2024
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to improve GHA reliability. Follows JDK-8325194. GHA passes. Risk is low: infrastructure change.

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@shipilev
8340418: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 24, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 3, 2024
@shipilev
Copy link
Member Author

shipilev commented Oct 4, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

Going to push as commit e241385.
Since your change was applied there have been 24 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2024
@openjdk openjdk bot closed this Oct 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2024
@openjdk
Copy link

openjdk bot commented Oct 4, 2024

@shipilev Pushed as commit e241385.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant