Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225377: type annotations are not visible to javac plugins across compilation boundaries #1250

Closed
wants to merge 1 commit into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Dec 17, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8341779 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request matching fixVersion 21.0.7 to be approved (needs to be created)
  • JDK-8225377 needs maintainer approval

Integration blocker

 ⚠️ Dependency #1037 must be integrated first

Warning

 ⚠️ Found leading lowercase letter in issue title for 8225377: type annotations are not visible to javac plugins across compilation boundaries

Issues

  • JDK-8225377: type annotations are not visible to javac plugins across compilation boundaries (Bug - P3 - Approved)
  • JDK-8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1250/head:pull/1250
$ git checkout pull/1250

Update a local copy of the PR:
$ git checkout pull/1250
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1250

View PR using the GUI difftool:
$ git pr show -t 1250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1250.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2024

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into pr/1037 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport de6667cf11aa59d1bab78ae5fb235ea0b901d5c4 8225377: type annotations are not visible to javac plugins across compilation boundaries Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Dec 17, 2024
@cushon
Copy link
Contributor Author

cushon commented Dec 17, 2024

/issue add JDK-8341779

@cushon
Copy link
Contributor Author

cushon commented Dec 17, 2024

/issue remove JDK-8225377

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@cushon
Adding additional issue to issue list: 8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries.

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@cushon The issue 8225377 was not found in the list of additional solved issues. The list currently contains these issues: 8341779

@cushon cushon closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport csr Pull request needs approved CSR before integration
Development

Successfully merging this pull request may close these issues.

1 participant