Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337795: Type annotation attached to incorrect type during class reading #1252

Open
wants to merge 1 commit into
base: pr/1251
Choose a base branch
from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Dec 17, 2024

This is a backport of JDK-8337795, which is a follow-up to JDK-8225377.


Progress

  • JDK-8337795 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #1251 must be integrated first

Issue

  • JDK-8337795: Type annotation attached to incorrect type during class reading (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1252/head:pull/1252
$ git checkout pull/1252

Update a local copy of the PR:
$ git checkout pull/1252
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1252

View PR using the GUI difftool:
$ git pr show -t 1252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1252.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2024

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into pr/1251 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8d0831478338e9b084b2c47f46eba9faae3a5eb6 8337795: Type annotation attached to incorrect type during class reading Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 17, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant