-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8342988: GHA: Build JTReg in single step #1269
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
f6ed0b3
to
8fe45ca
Compare
|
/approval request Makes sure GHA is more reliable: we do not risk failures when building jtreg multiple times, and it also allows us to compile it once on x86, without bothering with different arch JDKs. Does not apply cleanly, because Alpine changes are missing in 21u. Otherwise clean, GHA tests pass. Risk is low, GHA-only change. |
It would be great if this reduces the wget failures!!! |
Right? :) In mainline, the failures are still happening occasionally, but at least they fail in the first minute, so you can restart the testing right away. /integrate |
Going to push as commit 6e6f8b2.
Your commit was automatically rebased without conflicts. |
Makes sure GHA is more reliable: we do not risk failures when building jtreg multiple times, and it also allows us to compile it once on x86, without bothering with different arch JDKs.
The original PR does not apply cleanly, because Alpine support added by JDK-8282944 is not in JDK 21. I have resolved the block by hand.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1269/head:pull/1269
$ git checkout pull/1269
Update a local copy of the PR:
$ git checkout pull/1269
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1269/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1269
View PR using the GUI difftool:
$ git pr show -t 1269
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1269.diff
Using Webrev
Link to Webrev Comment