Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342609: jpackage test helper function incorrectly removes a directory instead of its contents only #1286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 23, 2024

I backport this for parity with 21.0.7-oracle.

Resolved Copyright, probably clean anyways.


Progress

  • JDK-8342609 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only

Issue

  • JDK-8342609: jpackage test helper function incorrectly removes a directory instead of its contents only (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1286/head:pull/1286
$ git checkout pull/1286

Update a local copy of the PR:
$ git checkout pull/1286
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1286/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1286

View PR using the GUI difftool:
$ git pr show -t 1286

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1286.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342609: jpackage test helper function incorrectly removes a directory instead of its contents only

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 36b067c: 8345414: Google CAInterop test failures
  • 182e949: 8342602: Remove JButton/PressedButtonRightClickTest test
  • fe9284a: 8343101: Rework BasicTest.testTemp test cases
  • 85e5a5c: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms
  • bf86b34: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java
  • 173c3d3: 8333647: C2 SuperWord: some additional PopulateIndex tests
  • 3aa331d: 8326421: Add jtreg test for large arrayCopy disjoint case.
  • f3e7bb4: 8329210: Delete Redundant Printer Dialog Modality Test
  • d91dba3: 8315883: Open source several Swing JToolbar tests
  • a98f9cf: 8316056: Open source several Swing JTree tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7133d1b983d7b85ba3c8dde26eb654c7ab695b07 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant