-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8342609: jpackage test helper function incorrectly removes a directory instead of its contents only #1286
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
I backport this for parity with 21.0.7-oracle.
Resolved Copyright, probably clean anyways.
Progress
Warning
8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1286/head:pull/1286
$ git checkout pull/1286
Update a local copy of the PR:
$ git checkout pull/1286
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1286/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1286
View PR using the GUI difftool:
$ git pr show -t 1286
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1286.diff
Using Webrev
Link to Webrev Comment