-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8325529: Remove unused imports from ModuleGenerator
test file
#1306
8325529: Remove unused imports from ModuleGenerator
test file
#1306
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
ModuleGenerator
test file
This backport pull request has now been updated with issue from the original commit. |
|
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for the reviews! |
/integrate |
Going to push as commit 4035d85.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 21.0.7-oracle
The backport is clean, but the tests need one of the old imports. See extra commit.
Progress
Issue
ModuleGenerator
test file (Bug - P4 - Approved)Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1306/head:pull/1306
$ git checkout pull/1306
Update a local copy of the PR:
$ git checkout pull/1306
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1306/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1306
View PR using the GUI difftool:
$ git pr show -t 1306
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1306.diff
Using Webrev
Link to Webrev Comment