Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325529: Remove unused imports from ModuleGenerator test file #1306

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 8, 2025

I backport this for parity with 21.0.7-oracle

The backport is clean, but the tests need one of the old imports. See extra commit.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325529 needs maintainer approval

Issue

  • JDK-8325529: Remove unused imports from ModuleGenerator test file (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1306/head:pull/1306
$ git checkout pull/1306

Update a local copy of the PR:
$ git checkout pull/1306
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1306/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1306

View PR using the GUI difftool:
$ git pr show -t 1306

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1306.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 8, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325529: Remove unused imports from `ModuleGenerator` test file

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 405a892: 8339542: compiler/codecache/CheckSegmentedCodeCache.java fails
  • 92171b8: 8325659: Normalize Random usage by incubator vector tests
  • b160465: 8198237: [macos] Test java/awt/Frame/ExceptionOnSetExtendedStateTest/ExceptionOnSetExtendedStateTest.java fails
  • a04daf6: 8327505: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails
  • be0da80: 8327994: Update code gen in CallGeneratorHelper
  • 6bc25f3: 8317636: Improve heap walking API tests to verify correctness of field indexes
  • 6e6d7b2: 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux
  • 79ba88a: 8317283: jpackage tests run osx-specific checks on windows and linux
  • 25bb646: 8312570: [TESTBUG] Jtreg compiler/loopopts/superword/TestDependencyOffsets.java fails on 512-bit SVE
  • 9e451b4: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser
  • ... and 5 more: https://git.openjdk.org/jdk21u-dev/compare/6514d380d1de1368b7db091e592bdc3e076277f4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d70156d2e2eddc311af12bc016b1ebb70efd92dd 8325529: Remove unused imports from ModuleGenerator test file Jan 8, 2025
@openjdk
Copy link

openjdk bot commented Jan 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 8, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 8, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2025

Webrevs

@openjdk openjdk bot removed the clean label Jan 9, 2025
Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@GoeLin
Copy link
Member Author

GoeLin commented Jan 13, 2025

Thanks for the reviews!

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 13, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Jan 14, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 14, 2025

Going to push as commit 4035d85.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 405a892: 8339542: compiler/codecache/CheckSegmentedCodeCache.java fails
  • 92171b8: 8325659: Normalize Random usage by incubator vector tests
  • b160465: 8198237: [macos] Test java/awt/Frame/ExceptionOnSetExtendedStateTest/ExceptionOnSetExtendedStateTest.java fails
  • a04daf6: 8327505: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails
  • be0da80: 8327994: Update code gen in CallGeneratorHelper
  • 6bc25f3: 8317636: Improve heap walking API tests to verify correctness of field indexes
  • 6e6d7b2: 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux
  • 79ba88a: 8317283: jpackage tests run osx-specific checks on windows and linux
  • 25bb646: 8312570: [TESTBUG] Jtreg compiler/loopopts/superword/TestDependencyOffsets.java fails on 512-bit SVE
  • 9e451b4: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser
  • ... and 5 more: https://git.openjdk.org/jdk21u-dev/compare/6514d380d1de1368b7db091e592bdc3e076277f4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 14, 2025
@openjdk openjdk bot closed this Jan 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 14, 2025
@openjdk
Copy link

openjdk bot commented Jan 14, 2025

@GoeLin Pushed as commit 4035d85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants