Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331572: Allow using OopMapCache outside of STW GC phases #610

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented May 28, 2024

WIP. Unclean backport to improve GC and general stack walk performance when walking interpreted frames.

The point of uncleanliness comes from the way we hook up the cleanup notifications to Service Thread. In later JDKs, JDK-8329488 made Service Thread wake up regularly to do various cleanups. In JDK 21, we still need to hook up the clean up to the "usual" place in safepoint epilog.

Additional testing:

  • Linux x86_64 server fastdebug, all

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8331572 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8334594 needs maintainer approval

Issues

  • JDK-8331572: Allow using OopMapCache outside of STW GC phases (Enhancement - P4)
  • JDK-8334594: Generational ZGC: Deadlock after OopMap rewrites in 8331572 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/610/head:pull/610
$ git checkout pull/610

Update a local copy of the PR:
$ git checkout pull/610
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/610/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 610

View PR using the GUI difftool:
$ git pr show -t 610

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/610.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 28, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d999b81e7110751be402012e1ed41b3256f5895e 8331572: Allow using OopMapCache outside of STW GC phases May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 28, 2024
@shipilev shipilev force-pushed the JDK-8331572-oopmap-cache-all branch 3 times, most recently from 21c0383 to 9883745 Compare May 31, 2024 09:45
@shipilev shipilev force-pushed the JDK-8331572-oopmap-cache-all branch from 9883745 to b2438fb Compare June 4, 2024 09:07
@shipilev shipilev marked this pull request as ready for review June 4, 2024 16:51
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 7, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

/issue add JDK-8334594

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@shipilev
Adding additional issue to issue list: 8334594: Generational ZGC: Deadlock after OopMap rewrites in 8331572.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants