8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test

[luchenlin]

I backport this for parity with 21.0.5-oracle.
backport with JDK-8328269, both clean.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8328158 needs maintainer approval
• Commit message must refer to an issue
• JDK-8328269 needs maintainer approval

Issues

• JDK-8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test (Bug - P4 - Approved)
• JDK-8328269: NonFocusablePopupMenuTest.java should be marked as headful (Bug - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/810/head:pull/810
$ git checkout pull/810

Update a local copy of the PR:
$ git checkout pull/810
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/810/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 810

View PR using the GUI difftool:
$ git pr show -t 810

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/810.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test
8328269: NonFocusablePopupMenuTest.java should be marked as headful

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• dc3d552: 8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp
• 8a0dd93: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
• 9677a85: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
• 9c9a812: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out
• 6ff7e2a: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
• 2c2cd9b: 8327401: Some jtreg tests fail on Wayland without any tracking bug
• 3e638bf: 8316361: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN with -XX:VerifyIterativeGVN=10
• b48b8e1: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
• 1064076: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
• 7991298: 8334653: ISO 4217 Amendment 177 Update
• ... and 8 more: https://git.openjdk.org/jdk21u-dev/compare/ded1a3379c9e55137b2ebaadf7246a0beae829d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7055e27d)
• 00: Full (0019e1d0)

[Eitanull]

Hi @Eitanull, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user Eitanull" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

• I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

[openjdk]

@Eitanull Only the author (@luchenlin) is allowed to issue the /issue command.

[luchenlin]

/issue add JDK-8328269

[openjdk]

@luchenlin
Adding additional issue to issue list: 8328269: NonFocusablePopupMenuTest.java should be marked as headful.

[luchenlin]

/integrate

[openjdk]

Going to push as commit 5f78ddd.
Since your change was applied there have been 18 commits pushed to the master branch:

• dc3d552: 8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp
• 8a0dd93: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
• 9677a85: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
• 9c9a812: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out
• 6ff7e2a: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
• 2c2cd9b: 8327401: Some jtreg tests fail on Wayland without any tracking bug
• 3e638bf: 8316361: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN with -XX:VerifyIterativeGVN=10
• b48b8e1: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
• 1064076: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
• 7991298: 8334653: ISO 4217 Amendment 177 Update
• ... and 8 more: https://git.openjdk.org/jdk21u-dev/compare/ded1a3379c9e55137b2ebaadf7246a0beae829d1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@luchenlin Pushed as commit 5f78ddd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.