8335536: Fix assertion failure in IdealGraphPrinter when append is true

[MaxXSoft]

Hi all,

This pull request contains a backport of commit 6db4c6a7 from the openjdk/jdk repository.

The commit being backported was authored by Qizheng Xing on 3 Jul 2024 and was reviewed by Tobias Hartmann, Christian Hagedorn and Tobias Holenstein.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• JDK-8335536 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8335536: Fix assertion failure in IdealGraphPrinter when append is true (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/816/head:pull/816
$ git checkout pull/816

Update a local copy of the PR:
$ git checkout pull/816
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/816/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 816

View PR using the GUI difftool:
$ git pr show -t 816

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/816.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back qxing! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MaxXSoft This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335536: Fix assertion failure in IdealGraphPrinter when append is true

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 9677a85: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
• 9c9a812: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out
• 6ff7e2a: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
• 2c2cd9b: 8327401: Some jtreg tests fail on Wayland without any tracking bug
• 3e638bf: 8316361: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN with -XX:VerifyIterativeGVN=10
• b48b8e1: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
• 1064076: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
• 7991298: 8334653: ISO 4217 Amendment 177 Update
• 7027274: 8333353: Delete extra empty line in CodeBlob.java
• c8fe1a1: 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64
• ... and 6 more: https://git.openjdk.org/jdk21u-dev/compare/ded1a3379c9e55137b2ebaadf7246a0beae829d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @MaxXSoft This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (2d0fea08)

[MaxXSoft]

/approval request Backporting this patch fixes assertion failures when debugging on ideal graph. Applies cleanly and risk is low.

[openjdk]

@MaxXSoft
8335536: The approval request has been created successfully.

[MaxXSoft]

/integrate

[openjdk]

@MaxXSoft
Your change (at version 2d0fea0) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 8a0dd93.
Since your change was applied there have been 16 commits pushed to the master branch:

• 9677a85: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
• 9c9a812: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out
• 6ff7e2a: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
• 2c2cd9b: 8327401: Some jtreg tests fail on Wayland without any tracking bug
• 3e638bf: 8316361: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN with -XX:VerifyIterativeGVN=10
• b48b8e1: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
• 1064076: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
• 7991298: 8334653: ISO 4217 Amendment 177 Update
• 7027274: 8333353: Delete extra empty line in CodeBlob.java
• c8fe1a1: 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64
• ... and 6 more: https://git.openjdk.org/jdk21u-dev/compare/ded1a3379c9e55137b2ebaadf7246a0beae829d1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @MaxXSoft Pushed as commit 8a0dd93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.