Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333542: Breakpoint in parallel code does not work #823

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 4, 2024

Backport of
8333542


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333542 needs maintainer approval

Issue

  • JDK-8333542: Breakpoint in parallel code does not work (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/823/head:pull/823
$ git checkout pull/823

Update a local copy of the PR:
$ git checkout pull/823
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/823/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 823

View PR using the GUI difftool:
$ git pr show -t 823

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/823.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b3bf31a0a08da679ec2fd21613243fb17b1135a9 8333542: Breakpoint in parallel code does not work Jul 4, 2024
@openjdk
Copy link

openjdk bot commented Jul 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2024

Webrevs

@MBaesken
Copy link
Member Author

MBaesken commented Jul 4, 2024

src/hotspot/share/classfile/vmSymbols.hpp
int_array_signature is already in 21u-dev so no change to this file - we have 1 file less in this PR compared to head
Some other files have diffs in the strides and minor diff.

cpCache.cpp
has different coding in set_method_handle_common

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@plummercj
Copy link
Contributor

Make sure JDK-8335134 also gets backported after this backport is complete.

@MBaesken
Copy link
Member Author

MBaesken commented Jul 9, 2024

Make sure JDK-8335134 also gets backported after this backport is complete.

Thanks for the hint, it is already labeled sap-interest1 , so planned to be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
3 participants