Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315505: CompileTask timestamp printed can overflow #827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neethu-prasad
Copy link
Contributor

@neethu-prasad neethu-prasad commented Jul 5, 2024

Backport of JDK-8315505.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315505 needs maintainer approval

Issue

  • JDK-8315505: CompileTask timestamp printed can overflow (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/827/head:pull/827
$ git checkout pull/827

Update a local copy of the PR:
$ git checkout pull/827
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/827/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 827

View PR using the GUI difftool:
$ git pr show -t 827

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/827.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2024

👋 Welcome back nprasad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@neethu-prasad This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315505: CompileTask timestamp printed can overflow

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • c8db6fe: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file
  • cb40bc2: 8315923: pretouch_memory by atomic-add-0 fragments huge pages unexpectedly
  • bbcce3f: 8331518: Tests should not use the "Classpath" exception form of the legal header
  • 5f78ddd: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test
  • dc3d552: 8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp
  • 8a0dd93: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
  • 9677a85: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
  • 9c9a812: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out
  • 6ff7e2a: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
  • 2c2cd9b: 8327401: Some jtreg tests fail on Wayland without any tracking bug

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ad7a8e86e0334390f87ae44cf749d2b47f1409a1 8315505: CompileTask timestamp printed can overflow Jul 5, 2024
@openjdk
Copy link

openjdk bot commented Jul 5, 2024

This backport pull request has now been updated with issue from the original commit.

@neethu-prasad neethu-prasad marked this pull request as ready for review July 8, 2024 00:25
@openjdk
Copy link

openjdk bot commented Jul 8, 2024

⚠️ @neethu-prasad This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2024

Webrevs

@neethu-prasad
Copy link
Contributor Author

/approval request Backport to fix CompileTask timestamp printed can overflow; applies cleanly; All tests passed; Risk is low: code change is simple and there are no follow-up bug since mainline integration 9 months ago.

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@neethu-prasad
8315505: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
1 participant