-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8335912: Add an operation mode to the jar command when extracting to not overwriting existing files #227
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the |
@slowhog, Thank you for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexeybakhtin for contributing this backport. Looks good to me.
Thank you for the review |
Please review the JAR tool enhancement.
It allows suppressing the overwriting of existing files with a new cmd line option.
The backport is almost clean except of src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java line 264
OptionType.EXTRACT was defined by JDK-8173970 but not backported to JDK23 yet.
All related JTREG tests passed
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/227/head:pull/227
$ git checkout pull/227
Update a local copy of the PR:
$ git checkout pull/227
$ git pull https://git.openjdk.org/jdk23u.git pull/227/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 227
View PR using the GUI difftool:
$ git pr show -t 227
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/227.diff
Using Webrev
Link to Webrev Comment