Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335912: Add an operation mode to the jar command when extracting to not overwriting existing files #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexeybakhtin
Copy link

@alexeybakhtin alexeybakhtin commented Nov 19, 2024

Please review the JAR tool enhancement.
It allows suppressing the overwriting of existing files with a new cmd line option.
The backport is almost clean except of src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java line 264
OptionType.EXTRACT was defined by JDK-8173970 but not backported to JDK23 yet.

All related JTREG tests passed


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8344651 to be approved
  • JDK-8335912 needs maintainer approval

Issues

  • JDK-8335912: Add an operation mode to the jar command when extracting to not overwriting existing files (Enhancement - P5 - Requested)
  • JDK-8344651: Add an operation mode to the jar command when extracting to not overwriting existing files (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/227/head:pull/227
$ git checkout pull/227

Update a local copy of the PR:
$ git checkout pull/227
$ git pull https://git.openjdk.org/jdk23u.git pull/227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 227

View PR using the GUI difftool:
$ git pr show -t 227

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/227.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2024

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files Nov 19, 2024
@openjdk
Copy link

openjdk bot commented Nov 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 19, 2024
@openjdk
Copy link

openjdk bot commented Nov 19, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Nov 19, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2024

Webrevs

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 20, 2024
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot added rfr Pull request is ready for review approval and removed csr Pull request needs approved CSR before integration labels Nov 20, 2024
@alexeybakhtin
Copy link
Author

@slowhog, Thank you for review.
Can anybody with reviewer status look at this PR in addition please?

Copy link
Contributor

@martinuy martinuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexeybakhtin for contributing this backport. Looks good to me.

@alexeybakhtin
Copy link
Author

Thanks @alexeybakhtin for contributing this backport. Looks good to me.

Thank you for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants