-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure #492
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue and summary from the original commit. |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@ktakakuri This pull request is now open |
Could someone please review this backport? |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@ktakakuri This pull request is now open |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Could someone please review this backport? |
|
/approval request I would like to backport this patch for test maintainability in JDK8. The backport is clean except for one test which has already been fixed. The risk is low as this only touches tests. There is a related patch JDK-8048892 and the corresponding backport has been submitted. |
@ktakakuri |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
1 similar comment
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
This pull request is pending approval of the Fix Request. |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
This pull request is pending approval of the Fix Request. |
Hi all,
I would like to backport this patch to improve test maintainability.
Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption.
Given this, the @debuggeeVMOptions mechanism can be safely removed.
The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch.
There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493
Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved.
Testing: All tests under jdk/test/com/sun/jdi
Thank you.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/492/head:pull/492
$ git checkout pull/492
Update a local copy of the PR:
$ git checkout pull/492
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/492/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 492
View PR using the GUI difftool:
$ git pr show -t 492
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/492.diff
Using Webrev
Link to Webrev Comment