-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8335978: [8u] incorrect include file name in semaphore.inline.hpp #543
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
The GHA report several failures.
|
/approval request Fxi incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low. |
@sendaoYan |
interfaceSupport.inline.hpp doesn't exist in 8u. GHA failures appear unrelated. |
Thanks for the review. |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/approval cancel |
@sendaoYan |
/approval request Fxi incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low. |
1 similar comment
/approval request Fxi incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low. |
|
@sendaoYan |
@sendaoYan |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/approval request Fix incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low. |
@sendaoYan |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/open |
@sendaoYan This pull request is already open |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@sendaoYan |
/approval request Fix incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low. |
@sendaoYan |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/open |
@sendaoYan This pull request is already open |
Hi all,
In file semaphore.inline.hpp,
#include "runtime/interfaceSupport.inline.hpp"
include incorrect file name, the crrect file name shoule be interfaceSupport.hpp in jdk8u repository.Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/543/head:pull/543
$ git checkout pull/543
Update a local copy of the PR:
$ git checkout pull/543
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/543/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 543
View PR using the GUI difftool:
$ git pr show -t 543
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/543.diff
Using Webrev
Link to Webrev Comment