8334657: Enable binary check

[kevinrushforth]

This PR enables two warnings that are now (or soon will be) enabled in the jdk repo:

1. Binary file check -- this will alert the reviewers of a PR that the patch being reviewed includes one or more binary files.
2. Issue title check -- this will check for two common (minor) formatting issues with the JBS title and matching PR title, a trailing period or a leading lower-case word.

Both are informational warnings that will not block integration.

To see how the warnings look, refer to the following Draft PRs:

1. PR with binary file: 8334674: Test new PNG file #1478
2. PR for bug with trailing period: 8334672: This is a test of the issuestitle check. #1479

/issue add 8334656
/reviewers 2

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

• JDK-8334657: Enable binary check (Bug - P3)
• JDK-8334656: Enable issuestitle check (Bug - P4)

Reviewers

• Ambarish Rapte (@arapte - Reviewer)
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1483/head:pull/1483
$ git checkout pull/1483

Update a local copy of the PR:
$ git checkout pull/1483
$ git pull https://git.openjdk.org/jfx.git pull/1483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1483

View PR using the GUI difftool:
$ git pr show -t 1483

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1483.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334657: Enable binary check
8334656: Enable issuestitle check

Reviewed-by: arapte, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• e9b10ab: 8334731: GHA: build on macOS / aarch64
• 17c2dba: 8334739: XYChart and (Stacked)AreaChart properties return incorrect beans
• c0216ae: 8088923: IOOBE when adding duplicate categories to the BarChart
• 6a586b6: 8331765: Websocket callbacks are not executed after WebKit 617.1 update

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kevinrushforth
Adding additional issue to issue list: 8334656: Enable issuestitle check.

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[mlbridge]

Webrevs

• 00: Full (3203bd99)

[kevinrushforth]

Reviewer: @arapte

[kevinrushforth]

/integrate

[openjdk]

Going to push as commit 101e517.
Since your change was applied there have been 5 commits pushed to the master branch:

• 83c8dcc: 8327255: javac lint warnings: removal, missing-explicit-ctor
• e9b10ab: 8334731: GHA: build on macOS / aarch64
• 17c2dba: 8334739: XYChart and (Stacked)AreaChart properties return incorrect beans
• c0216ae: 8088923: IOOBE when adding duplicate categories to the BarChart
• 6a586b6: 8331765: Websocket callbacks are not executed after WebKit 617.1 update

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinrushforth Pushed as commit 101e517.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.