8347305: RichTextArea Follow-up

[andy-goryachev-oracle]

The changes:

• minor fixes in the behavior document (DELETE_WORD_PREVIOUS)
• Default width of RTA is less than half the size of TextArea (176 vs 478 on my Windows 11 system). Earlier the height was also too small, but you already fixed that.
• addWithStyles --> addWithStyleNames

The following is not an issue (works as designed):

• When running the demos, the current line highlight overlaps and obscures focus outline on right side (verified on Windows and Linux).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347305: RichTextArea Follow-up (Bug - P4)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1671/head:pull/1671
$ git checkout pull/1671

Update a local copy of the PR:
$ git checkout pull/1671
$ git pull https://git.openjdk.org/jfx.git pull/1671/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1671

View PR using the GUI difftool:
$ git pr show -t 1671

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1671.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347305: RichTextArea Follow-up

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 0f6b8c5: 8345188: Support tree-structural pseudo-classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (ec8cdf42)
• 00: Full (694920a3)

[kevinrushforth]

The following is not an issue (works as designed):

• When running the demos, the current line highlight overlaps and obscures focus outline on right side (verified on Windows and Linux).

It might just be an issue with the demo, because I don't see it on a simple test program I wrote. Whether or not it works as designed, it looks ugly (and it's distracting as you navigate down the page with the keyboard). Here is a screen shot.

Anyway, I don't mind addressing this later, and not part of this PR.

[andy-goryachev-oracle]

It might just be an issue with the demo,

I see "use content width" option enabled, this is not the right use case. When the RTA is constrained, the useContentWidth should be off.

[kevinrushforth]

It looks like you missed capturing the bug for this comment. The second example in the RTA class docs doesn't compile. It needs to be updated to reflect an earlier change in the API:

addWithStyles --> addWithStyleNames

Can you either fix it as part of this PR or file a new bug?

[kevinrushforth]

LGTM